optimize DoubleConverter

chenby@nextop.cn · chenby@nextop.cn · commit eb580aa531b5 · 2017-01-25T17:20:37.000+08:00
diff --git a/quickfixj-core/src/main/java/quickfix/field/converter/DoubleConverter.java b/quickfixj-core/src/main/java/quickfix/field/converter/DoubleConverter.java
@@ -106,7 +106,7 @@ private static double parseDouble(String value) {
         for (; i < value.length(); i++) {
             c = value.charAt(i);
             if (!dot && c == '.') dot = true;
-            else if (!Character.isDigit(c)) throw new NumberFormatException(value);
+            else if (c < '0' || c > '9') throw new NumberFormatException(value);
         }
         return Double.parseDouble(value);
     }

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ private static double parseDouble(String value) {`
`106`	`106`	`for (; i < value.length(); i++) {`
`107`	`107`	`c = value.charAt(i);`
`108`	`108`	`if (!dot && c == '.') dot = true;`
`109`		`- else if (!Character.isDigit(c)) throw new NumberFormatException(value);`
	`109`	`+ else if (c < '0' \|\| c > '9') throw new NumberFormatException(value);`
`110`	`110`	`}`
`111`	`111`	`return Double.parseDouble(value);`
`112`	`112`	`}`