Merge pull request #1056 from the-thing/remove-closed

chrjohn · web-flow · commit 5db3e694fb01 · 2025-10-04T17:43:31.000+02:00
Remove unnecessary `IoSession.close()` for session that is already closed
diff --git a/quickfixj-core/src/main/java/quickfix/mina/AbstractIoHandler.java b/quickfixj-core/src/main/java/quickfix/mina/AbstractIoHandler.java
@@ -127,7 +127,6 @@ public void sessionClosed(IoSession ioSession) {
             throw e;
         } finally {
             ioSession.removeAttribute(SessionConnector.QF_SESSION);
-            ioSession.closeOnFlush();
         }
     }
 
diff --git a/quickfixj-core/src/main/java/quickfix/mina/initiator/InitiatorProxyIoHandler.java b/quickfixj-core/src/main/java/quickfix/mina/initiator/InitiatorProxyIoHandler.java
@@ -36,7 +36,7 @@ public void sessionCreated(IoSession session) throws Exception {
     }
 
     @Override
-    public void sessionClosed(IoSession ioSession) throws Exception {
+    public void sessionClosed(IoSession ioSession) {
         this.initiatorIoHandler.sessionClosed(ioSession);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,6 @@ public void sessionClosed(IoSession ioSession) {`
`127`	`127`	`throw e;`
`128`	`128`	`} finally {`
`129`	`129`	`ioSession.removeAttribute(SessionConnector.QF_SESSION);`
`130`		`- ioSession.closeOnFlush();`
`131`	`130`	`}`
`132`	`131`	`}`
`133`	`132`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public void sessionCreated(IoSession session) throws Exception {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`@Override`
`39`		`- public void sessionClosed(IoSession ioSession) throws Exception {`
	`39`	`+ public void sessionClosed(IoSession ioSession) {`
`40`	`40`	`this.initiatorIoHandler.sessionClosed(ioSession);`
`41`	`41`	`}`
`42`	`42`