Skip to content

Commit 0f9e964

Browse files
committed
post mina custom ssl filter removal
1 parent 14a28b4 commit 0f9e964

File tree

3 files changed

+4
-43
lines changed

3 files changed

+4
-43
lines changed

quickfixj-core/src/main/java/quickfix/mina/CustomSslFilter.java

Lines changed: 0 additions & 35 deletions
This file was deleted.

quickfixj-core/src/main/java/quickfix/mina/acceptor/AbstractSocketAcceptor.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
import quickfix.SessionID;
4141
import quickfix.SessionSettings;
4242
import quickfix.mina.CompositeIoFilterChainBuilder;
43-
import quickfix.mina.CustomSslFilter;
4443
import quickfix.mina.EventHandlingStrategy;
4544
import quickfix.mina.NetworkingOptions;
4645
import quickfix.mina.ProtocolFactory;
@@ -135,7 +134,7 @@ private void installSSL(AcceptorSocketDescriptor descriptor,
135134
log.info("Installing SSL filter for {}", descriptor.getAddress());
136135
SSLConfig sslConfig = descriptor.getSslConfig();
137136
SSLContext sslContext = SSLContextFactory.getInstance(sslConfig);
138-
SslFilter sslFilter = new CustomSslFilter(sslContext);
137+
SslFilter sslFilter = new SslFilter(sslContext);
139138
sslFilter.setNeedClientAuth(sslConfig.isNeedClientAuth());
140139
sslFilter.setEnabledCipherSuites(sslConfig.getEnabledCipherSuites() != null ? sslConfig.getEnabledCipherSuites()
141140
: SSLSupport.getDefaultCipherSuites(sslContext));

quickfixj-core/src/main/java/quickfix/mina/initiator/IoSessionInitiator.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import quickfix.SessionSettings;
3535
import quickfix.SystemTime;
3636
import quickfix.mina.CompositeIoFilterChainBuilder;
37-
import quickfix.mina.CustomSslFilter;
3837
import quickfix.mina.EventHandlingStrategy;
3938
import quickfix.mina.NetworkingOptions;
4039
import quickfix.mina.ProtocolFactory;
@@ -159,9 +158,8 @@ private void setupIoConnector() throws ConfigError, GeneralSecurityException {
159158

160159
boolean hasProxy = proxyType != null && proxyPort > 0 && socketAddresses[nextSocketAddressIndex] instanceof InetSocketAddress;
161160

162-
SslFilter sslFilter = null;
163161
if (sslEnabled) {
164-
sslFilter = installSslFilter(ioFilterChainBuilder);
162+
installSslFilter(ioFilterChainBuilder);
165163
}
166164

167165
ioFilterChainBuilder.addLast(FIXProtocolCodecFactory.FILTER_NAME, new ProtocolCodecFilter(new FIXProtocolCodecFactory()));
@@ -192,17 +190,16 @@ private void setupIoConnector() throws ConfigError, GeneralSecurityException {
192190
ioConnector = newConnector;
193191
}
194192

195-
private SslFilter installSslFilter(CompositeIoFilterChainBuilder ioFilterChainBuilder)
193+
private void installSslFilter(CompositeIoFilterChainBuilder ioFilterChainBuilder)
196194
throws GeneralSecurityException {
197195
final SSLContext sslContext = SSLContextFactory.getInstance(sslConfig);
198-
final SslFilter sslFilter = new CustomSslFilter(sslContext, false);
196+
final SslFilter sslFilter = new SslFilter(sslContext, false);
199197
sslFilter.setEnabledCipherSuites(sslConfig.getEnabledCipherSuites() != null ? sslConfig.getEnabledCipherSuites()
200198
: SSLSupport.getDefaultCipherSuites(sslContext));
201199
sslFilter.setEnabledProtocols(sslConfig.getEnabledProtocols() != null ? sslConfig.getEnabledProtocols()
202200
: SSLSupport.getSupportedProtocols(sslContext));
203201
sslFilter.setEndpointIdentificationAlgorithm(sslConfig.getEndpointIdentificationAlgorithm());
204202
ioFilterChainBuilder.addLast(SSLSupport.FILTER_NAME, sslFilter);
205-
return sslFilter;
206203
}
207204

208205
@Override

0 commit comments

Comments
 (0)