Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about test cases #87

Open
lishoulong opened this issue Oct 18, 2021 · 0 comments
Open

Questions about test cases #87

lishoulong opened this issue Oct 18, 2021 · 0 comments

Comments

@lishoulong
Copy link

Hi, I have a question about the test cases.

`https://github.com/que-etc/resize-observer-polyfill/blob/master/tests/node/ResizeObserver.spec.node.js`
vs
`https://github.com/que-etc/resize-observer-polyfill/blob/master/tests/ResizeObserver.spec.js`

Now our test case is distributed into two types: bare jasmine and jasmine with karma.

From perspective of concise, I suggest we should merge the above two types into jasmine with karma.

So can someone show me the motivation of this design?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant