Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidance for testing a Liquibase fix for quarkus-liquibase extension #38614

Closed
tati-qalified opened this issue Feb 6, 2024 · 7 comments
Closed
Labels
area/liquibase kind/question Further information is requested triage/needs-feedback We are waiting for feedback.

Comments

@tati-qalified
Copy link

Description

Hi! I'm part of the Liquibase team, and recently we've received some tickets regarding your quarkus-liquibase extension.
They're related to some changes on our side, so we're interested in fixing them.

Looking into the extension, the only way we've found to test our fixes is:

  1. Build a jar file for our fix
  2. Import it locally to the extension source code
  3. Build the jar file for the extension
  4. Create a project that uses quarkus-liquibase
  5. Import the custom jar file

We worry that there are many possible points of failure, mainly considering the version compatibility for multiple dependencies.

Is there a way we could simplify the process?

Thank you,
Tatiana

Implementation ideas

No response

@tati-qalified tati-qalified added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Feb 6, 2024
Copy link

quarkus-bot bot commented Feb 6, 2024

/cc @andrejpetras (liquibase), @geoand (liquibase), @gsmet (liquibase)

@geoand
Copy link
Contributor

geoand commented Feb 7, 2024

Hello,

First of all, thanks for reaching out.

If I were you, here is how I would go about testing my fixes:

  1. Enhance the liquibase integration test with the currently failing cases
  2. Update the version of Liquibase used in Quarkus to some snapshot version of Liquibase I am working on
  3. Make my liquibase changes and install them locally (I assume mvn install ... is all you need)
  4. Possibly make changes to the Quarkus liquibase extension (mvn install -f extensions/liquibase)
  5. Run the integration test (mvn verify -f integration-tests/liquibase -Dnative) to see whether it now passes
  6. Repeat 3-5 as needed

Does this make sense?

@geoand geoand added kind/question Further information is requested triage/needs-feedback We are waiting for feedback. and removed area/housekeeping Issue type for generalized tasks not related to bugs or enhancements labels Feb 7, 2024
@gsmet
Copy link
Member

gsmet commented Feb 7, 2024

I would mvn install the BOM after 2 to be sure it's taken into account.

@MalloD12
Copy link

MalloD12 commented Feb 7, 2024

Hello,

First of all, thanks for reaching out.

If I were you, here is how I would go about testing my fixes:

  1. Enhance the liquibase integration test with the currently failing cases
  2. Update the version of Liquibase used in Quarkus to some snapshot version of Liquibase I am working on
  3. Make my liquibase changes and install them locally (I assume mvn install ... is all you need)
  4. Possibly make changes to the Quarkus liquibase extension (mvn install -f extensions/liquibase)
  5. Run the integration test (mvn verify -f integration-tests/liquibase -Dnative) to see whether it now passes
  6. Repeat 3-5 as needed

Does this make sense?

Hi @geoand,

On step 1, do you mean creating integration tests for liquibase-quarkus extension? At the moment, we don't support that extension in Liquibase.

Thanks,
Daniel.

@geoand
Copy link
Contributor

geoand commented Feb 7, 2024

Hi,

My point about 1 is that if your goal is to fix issues in the Quarkus + Liquibase integration, then you first need to have a way to reproduce the current problems - the integration test in Quarkus is an easy way to do so.

@geoand geoand removed the triage/needs-feedback We are waiting for feedback. label Feb 12, 2024
@geoand
Copy link
Contributor

geoand commented Feb 12, 2024

Is there anything more to do around this?

@geoand geoand added the triage/needs-feedback We are waiting for feedback. label Feb 12, 2024
@geoand
Copy link
Contributor

geoand commented Feb 26, 2024

Closing for lack of feedback

@geoand geoand closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/liquibase kind/question Further information is requested triage/needs-feedback We are waiting for feedback.
Projects
None yet
Development

No branches or pull requests

4 participants