Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a pagination interface to Panache #30385

Closed
hmbig2 opened this issue Jan 16, 2023 · 5 comments
Closed

add a pagination interface to Panache #30385

hmbig2 opened this issue Jan 16, 2023 · 5 comments
Labels
area/panache triage/invalid This doesn't seem right

Comments

@hmbig2
Copy link

hmbig2 commented Jan 16, 2023

Description

The Jakarta Data specification defines a pagination interface,
spring JPA has the same interface.

why didn't Quarkus-panache implement this interface?

Implementation ideas

No response

@hmbig2 hmbig2 added the kind/enhancement New feature or request label Jan 16, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 16, 2023

/cc @FroMage (panache), @loicmathieu (panache)

@cescoffier cescoffier changed the title add a panination interface to Panache add a pagination interface to Panache Jan 16, 2023
@mkouba
Copy link
Contributor

mkouba commented Jan 16, 2023

PanacheQuery does support pagination: https://quarkus.io/guides/hibernate-orm-panache#paging

@geoand
Copy link
Contributor

geoand commented Jan 16, 2023

@gavinking what is our position WRT Jakarta Data?

@codespearhead
Copy link

Should this issue be closed then?

@FroMage
Copy link
Member

FroMage commented Feb 12, 2024

why didn't Quarkus-panache implement this interface?

Because we don't implement Jakarta Data, because it's not released yet and Quarkus ORM with Panache is older than this and supports pagination already, as noted above :)

what is our position WRT Jakarta Data?

I believe our position is to wait until later to implement it.

Let's close this issue, we'll open another one to implement Jakarta Data later when/if we intend to implement it.

@FroMage FroMage closed this as completed Feb 12, 2024
@FroMage FroMage added triage/invalid This doesn't seem right and removed kind/enhancement New feature or request labels Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/panache triage/invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

5 participants