Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fn:parse-xml: xinclude #1857

Closed
ChristianGruen opened this issue Mar 3, 2025 · 4 comments · Fixed by #1879
Closed

fn:parse-xml: xinclude #1857

ChristianGruen opened this issue Mar 3, 2025 · 4 comments · Fixed by #1879
Labels
Enhancement A change or improvement to an existing feature PR Pending A PR has been raised to resolve this issue XQFO An issue related to Functions and Operators

Comments

@ChristianGruen
Copy link
Contributor

We should allow XInclude processing to be enabled/disabled, as it can potentially lead to memory leaks.

@ChristianGruen ChristianGruen added Enhancement A change or improvement to an existing feature XQFO An issue related to Functions and Operators labels Mar 3, 2025
@ndw
Copy link
Contributor

ndw commented Mar 3, 2025

Where does fn:parse-xml say that XInclude is ever performed? The only mention I see of XInclude is, somewhat amusingly, in fn:unparsed-text.

I'm not opposed to an option to enable it, but I don't think it should happen by default.

@ChristianGruen
Copy link
Contributor Author

Where does fn:parse-xml say that XInclude is ever performed? The only mention I see of XInclude is, somewhat amusingly, in fn:unparsed-text.

Good that you mention this. It seems that at least two processors (namely, Saxon and BaseX) have enabled it, but I didn’t check why.

@michaelhkay
Copy link
Contributor

We have a bit of a problem with parse-xml() on Saxon because it uses parsing options that are set globally at configuration level, and that's often inappropriate. XInclude certainly won't be enabled by default, but it will be affected by global settings.

@ChristianGruen
Copy link
Contributor Author

XInclude certainly won't be enabled by default, but it will be affected by global settings.

You are obviously right (and I was wrong); it was a -xi CLI option that enabled the XInclude processing.

@ChristianGruen ChristianGruen changed the title fn:parse-xml: xinclude option fn:parse-xml: xinclude, dtd-validation Mar 5, 2025
@ChristianGruen ChristianGruen changed the title fn:parse-xml: xinclude, dtd-validation fn:parse-xml: xinclude Mar 5, 2025
@michaelhkay michaelhkay added the PR Pending A PR has been raised to resolve this issue label Mar 14, 2025
@ndw ndw closed this as completed in #1879 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A change or improvement to an existing feature PR Pending A PR has been raised to resolve this issue XQFO An issue related to Functions and Operators
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants