Skip to content

Commit bdacb87

Browse files
author
Juha Vuolle
committed
Make autotests configurable without Widgets on Android
tst_android depends on widgets, and parts of the test needs to be excluded if Qt is configured without them. Pick-to: 6.9 6.8 Change-Id: Iaca5b4228c0a7bd7c3a2efe9da04f354ac7e7c1c Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
1 parent 2542d79 commit bdacb87

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

tests/auto/corelib/platform/android/CMakeLists.txt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,15 @@ qt_internal_add_test(tst_android
1818
Qt::CorePrivate
1919
Qt::Gui
2020
Qt::GuiPrivate
21-
Qt::Widgets
2221
)
2322

2423
if(ANDROID)
2524
set_property(TARGET tst_android APPEND PROPERTY QT_ANDROID_PACKAGE_SOURCE_DIR
2625
${CMAKE_CURRENT_SOURCE_DIR}/testdata
2726
)
2827
endif()
28+
29+
qt_internal_extend_target(tst_android CONDITION TARGET Qt::Widgets
30+
LIBRARIES
31+
Qt::Widgets
32+
)

tests/auto/corelib/platform/android/tst_android.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,10 @@
1212
#include <qpa/qplatformscreen.h>
1313
#include <qpa/qplatformnativeinterface.h>
1414
#include <QtCore/qdiriterator.h>
15+
#include <private/qglobal_p.h> // for widgets feature test
16+
#if QT_CONFIG(widgets)
1517
#include <QWidget>
18+
#endif
1619
#include <QSignalSpy>
1720

1821
using namespace Qt::StringLiterals;
@@ -37,9 +40,11 @@ private slots:
3740
void testAndroidSdkVersion();
3841
void testAndroidActivity();
3942
void testRunOnAndroidMainThread();
43+
#if QT_CONFIG(widgets)
4044
void testFullScreenDimensions();
4145
void orientationChange_data();
4246
void orientationChange();
47+
#endif
4348
};
4449

4550
void tst_Android::assetsRead()
@@ -213,6 +218,7 @@ void tst_Android::testRunOnAndroidMainThread()
213218
}
214219
}
215220

221+
#if QT_CONFIG(widgets)
216222
// QTBUG-107604
217223
void tst_Android::testFullScreenDimensions()
218224
{
@@ -400,6 +406,7 @@ void tst_Android::orientationChange()
400406
QCOMPARE(screen->size(), screenSize);
401407
QCOMPARE(widget.size(), screen->availableSize());
402408
}
409+
#endif // QT_CONFIG(widgets)
403410

404411
QTEST_MAIN(tst_Android)
405412
#include "tst_android.moc"

0 commit comments

Comments
 (0)