Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Libsodium cache is not being used. #75

Closed
qstokkink opened this issue Jun 14, 2024 · 3 comments · Fixed by #76
Closed

Libsodium cache is not being used. #75

qstokkink opened this issue Jun 14, 2024 · 3 comments · Fixed by #76
Assignees
Labels
bug Something isn't working

Comments

@qstokkink
Copy link
Owner

We have moved on from #61 and libsodium.dll is now being stored and restored from the cache_libsodium_dll cache without failing. However, apparently the unit test script is STILL unable to find it:

Failed to locate libsodium (libnacl requirement), downloading latest dll!
@qstokkink qstokkink added the bug Something isn't working label Jun 14, 2024
@qstokkink
Copy link
Owner Author

This may be due to the re-used logic from IPv8, in windows_missing_libsodium():

# Try to find it in the local directory. This is where we'll download it anyway.
os.add_dll_directory(os.path.dirname(__file__) or os.path.abspath('.'))

This file exists in ./pyipv8/run_all_tests.py. My assumption is that it:

  1. Attempts to find the libtorrent.dll in ./pyipv8/ and fails.
  2. Downloads libtorrent.dll to to the current directory.
  3. The tests pass.
  4. The cache is saved from the current directory correctly.

@qstokkink
Copy link
Owner Author

If my intuition is correct, I'll fix this in IPv8. First, I'll create a PR here to verify.

@qstokkink qstokkink self-assigned this Jun 14, 2024
@qstokkink
Copy link
Owner Author

Confirmed. Using . instead of os.path.dirname(__file__) fixes the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant