Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observability of async logging queue #754

Open
mathieufortin01 opened this issue Dec 22, 2023 · 6 comments
Open

Observability of async logging queue #754

mathieufortin01 opened this issue Dec 22, 2023 · 6 comments

Comments

@mathieufortin01
Copy link

Hello. Is there any way to gather metrics on the internal queue used by async logger? Things like current capacity, nb of info logs dropped, nb of logs dropped when full, etc.

If not available would that be an interesting contribution?

Thanks.

@tomershafir
Copy link

I think the library must export standard metrics. Buffer monitoring (cap, size, write count, flush count) and rotation monitoring (file set state, rotation count) are also necessary.

@ceki
Copy link
Member

ceki commented Jan 23, 2024

@mathieufortin01 Indeed, there seems to be interest in it.

@mathieufortin01
Copy link
Author

Great. Whats the best place to discuss scope/solution? As a side note, this could be a contribution by Autodesk.

@ceki
Copy link
Member

ceki commented Jan 23, 2024

@mathieufortin01 Here?

@mathieufortin01
Copy link
Author

mathieufortin01 commented Jan 30, 2024

@ceki So i would start with metrics around buffer usage in async mode, keeping in mind that other metrics could be added. Question is: Should the lib define metrics interface for major aggregators in the lib itself (like HikariCP is doing) or should it just provide hooks to receive metrics and caller is responsible to hook them up with micrometer, prometheus, etc ?

@ceki
Copy link
Member

ceki commented Jan 30, 2024

@mathieufortin01 I would keep it as simple as possible. Providing data around buffer usage sounds good, keeping in mind that other metrics could be added later as necessary. At this early stage, providing explicit support for metrics frameworks seems premature. We can always revisit the issue later.

If you wish to add support for metrics frameworks, this can be done in a separate logback extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants