test(bats): use random database names instead of the hardcoded "unittest"

Previously if a database named "unittest" pre-existed, it was dropped
and recreated unconditionally.
Now the tests generate a random database name, and use the environment
variable PPM_DATABASE to refer to it.
Additionally, PGDATABASE is used for the partition manager instead
of a hardcoded URL in the template file.

Signed-off-by: Daniel Vérité <[email protected]>

Author: dverite

scripts/bats/20_check.bats

@@ -5,7 +5,11 @@ load 'test/libs/seeds'
 load 'test/libs/sql'
 
 setup_file() {
-  reset_database
+  init_database
+}
+
+teardown_file() {
+  drop_database
 }
 
 setup() {

scripts/bats/30_provisioning.bats

@@ -6,7 +6,11 @@ load 'test/libs/sql'
 load 'test/libs/time'
 
 setup_file() {
-  reset_database
+  init_database
+}
+
+teardown_file() {
+  drop_database
 }
 
 setup() {
@@ -237,7 +241,7 @@ EOF
   assert_success
   assert_output --partial "All partitions are correctly provisioned"
 
-  run list_existing_partitions "unittest" "public" ${TABLE}
+  run list_existing_partitions "public" ${TABLE}
 
   local expected_monthly=$(cat <<EOF
 public|test_interv_2024_12|2024-12-01|2025-01-01
@@ -270,7 +274,7 @@ public|test_interv_2025_w15|2025-04-07|2025-04-14
 EOF
   )
 
-  run list_existing_partitions "unittest" "public" ${TABLE}
+  run list_existing_partitions "public" ${TABLE}
   assert_output "$expected_mix"
 
   rm "$CONFIGURATION_FILE"
@@ -311,7 +315,7 @@ public|table_unittest1_2025_02_01|2025-02-01|2025-02-02
 public|table_unittest1_2025_02_02|2025-02-02|2025-02-03
 EOF
   )
-  run list_existing_partitions "unittest" "public" "table_unittest1"
+  run list_existing_partitions "public" "table_unittest1"
   assert_output "$expected1"
 
   local expected2=$(cat <<'EOF'
@@ -323,7 +327,7 @@ public|table_unittest2_2025_02_03|2025-02-03|2025-02-04
 EOF
   )
 
-  run list_existing_partitions "unittest" "public" "table_unittest2"
+  run list_existing_partitions "public" "table_unittest2"
   assert_output "$expected2"
 
   rm "$CONFIGURATION_FILE"
@@ -373,7 +377,7 @@ public|${TABLE}_2025_02_03|2025-02-03|2025-02-04
 EOF
   )
 
-  run list_existing_partitions "unittest" "public" "${TABLE}"
+  run list_existing_partitions "public" "${TABLE}"
   assert_output "$expected2"
 
   rm "$CONFIGURATION_FILE"
@@ -406,7 +410,7 @@ public|${TABLE}_2025_w12|2025-03-17 00:00:00+01|2025-03-24 00:00:00+01
 EOF
   )
 
-  run list_existing_partitions "unittest" "public" ${TABLE}
+  run list_existing_partitions "public" ${TABLE}
   assert_output "$expected_1"
 
   # Now advance one week up to the end of March 2025
@@ -426,7 +430,7 @@ public|${TABLE}_2025_w12|2025-03-17 00:00:00+01|2025-03-24 00:00:00+01
 public|${TABLE}_2025_w13|2025-03-24 00:00:00+01|2025-03-31 00:00:00+02
 EOF
 )
-  run list_existing_partitions "unittest" "public" ${TABLE}
+  run list_existing_partitions "public" ${TABLE}
   assert_output "$expected_2"
 
   rm "$CONFIGURATION_FILE"

scripts/bats/40_cleanup.bats

@@ -5,7 +5,11 @@ load 'test/libs/seeds'
 load 'test/libs/sql'
 
 setup_file() {
-  reset_database
+  init_database
+}
+
+teardown_file() {
+  drop_database
 }
 
 setup() {
@@ -119,7 +123,7 @@ EOF
     expected+="public|${PARTS[i]}|${PARTS[i+1]}|${PARTS[i+2]}"
     (( i+=3 ))
   done
-  run list_existing_partitions "unittest" "public" "${TABLE}"
+  run list_existing_partitions "public" "${TABLE}"
 
   assert_output "$expected"
 

scripts/bats/configuration/template.yaml

@@ -3,4 +3,4 @@ debug: true
 
 log-format: text
 
-connection-url: postgres://postgres:hackme@localhost/unittest
+#connection-url: postgres://user:password@localhost/dbname

scripts/bats/test/libs/partitions.bash

@@ -41,7 +41,7 @@ generate_daily_partition() {
   local UPPER_BOUND=$(date -d "@$(( $(date +%s) + 86400 * $TIMEDELTA + 86400))" +"%Y-%m-%d")
 
   local QUERY="CREATE TABLE ${TABLE_NAME} PARTITION OF ${PARENT_TABLE} FOR VALUES FROM ('${LOWER_BOUND}') TO ('${UPPER_BOUND}');"
-  execute_sql "${QUERY}"
+  execute_sql "${QUERY}" "$PPM_DATABASE"
 }
 
 generate_daily_partition_name() {
@@ -85,5 +85,5 @@ create_partitions() {
     done
     sql_block="$sql_block
 		COMMIT;";
-    execute_sql_commands "$sql_block"
+    execute_sql_commands "$sql_block" "$PPM_DATABASE"
 }

scripts/bats/test/libs/seeds.bash

@@ -5,13 +5,17 @@ random_suffix() {
 }
 
 init_database() {
-  QUERY="CREATE DATABASE unittest;"
+  local dbname="ppm_test_"$(random_suffix)
+  QUERY="CREATE DATABASE \"$dbname\" ;"
   execute_sql "${QUERY}" postgres
+  export PPM_DATABASE="$dbname"
+  export PGDATABASE="$dbname"
 }
 
 drop_database() {
-  QUERY="set lock_timeout to '5s'; DROP DATABASE IF EXISTS unittest;"
+  QUERY="set lock_timeout to '5s'; DROP DATABASE IF EXISTS \"$PPM_DATABASE\" ;"
   execute_sql_commands "${QUERY}" postgres
+  unset PPM_DATABASE
 }
 
 reset_database() {
@@ -29,7 +33,7 @@ create_table_from_template() {
     created_at      DATE NOT NULL
   ) PARTITION BY RANGE (created_at);
 EOQ
-  execute_sql "${QUERY}"
+  execute_sql "${QUERY}" "${PPM_DATABASE}"
 }
 
 create_table_uuid_range() {

scripts/bats/test/libs/sql.bash

@@ -2,7 +2,7 @@ execute_sql() {
   local SQL_COMMAND=$1
   local DATABASE=$2
 
-  if [ -z ${DATABASE} ]; then
+  if [ -z "$DATABASE" ]; then
     psql --echo-all --echo-errors -c "${SQL_COMMAND}"
   else
     psql --echo-all --echo-errors --dbname="${DATABASE}" -c "${SQL_COMMAND}"
@@ -13,7 +13,7 @@ execute_sql_file() {
   local SQL_FILE=$1
   local DATABASE=$2
 
-  if [ -z ${DATABASE} ]; then
+  if [ -z "$DATABASE" ]; then
     psql --echo-all --echo-errors -f "${SQL_FILE}"
   else
     psql --echo-all --echo-errors --dbname="${DATABASE}" -f "${SQL_FILE}"
@@ -25,16 +25,23 @@ execute_sql_commands() {
   # $1: sql commands
   # $2: dbname (if unset, psql defaults to $PGDATABASE and then $USER)
 
-  psql --tuples-only --no-align --quiet "$2" <<EOSQL
+  local command="psql --tuples-only --no-align --quiet"
+
+  if [ ! -z "$2" ]; then
+    command="$command --dbname=$2"
+  fi
+
+  $command <<EOSQL
 $1
 EOSQL
 }
 
 list_existing_partitions() {
-  local DATABASE=$1
-  local PARENT_SCHEMA=$2
-  local PARENT_TABLE=$3
-  PGDATABASE="$DATABASE" psql --tuples-only --no-align --quiet -v parent_schema=${PARENT_SCHEMA} -v parent_table=${PARENT_TABLE} <<'EOSQL'
+  # mandatory arguments
+  local PARENT_SCHEMA=$1
+  local PARENT_TABLE=$2
+
+  psql --tuples-only --no-align --quiet --dbname="$PPM_DATABASE" -v parent_schema=${PARENT_SCHEMA} -v parent_table=${PARENT_TABLE} <<'EOSQL'
 WITH parts as (
 	SELECT
 	   relnamespace::regnamespace as schema,
@@ -58,8 +65,8 @@ EOSQL
 }
 
 assert_table_exists() {
-  local SCHEMA=$1
-  local TABLE=$2
+  local SCHEMA="$1"
+  local TABLE="$2"
 
   local QUERY="SELECT EXISTS (
     SELECT
@@ -68,15 +75,15 @@ assert_table_exists() {
     AND table_name = '${TABLE}'
   );"
 
-  run psql --tuples-only --no-align -c "${QUERY}"
+  run psql --dbname="$PPM_DATABASE" --tuples-only --no-align -c "${QUERY}"
 
   assert_success
   assert_output t
 }
 
 assert_table_not_exists() {
-  local SCHEMA=$1
-  local TABLE=$2
+  local SCHEMA="$1"
+  local TABLE="$2"
 
   local QUERY="SELECT EXISTS (
     SELECT
@@ -85,7 +92,7 @@ assert_table_not_exists() {
     AND table_name = '${TABLE}'
   );"
 
-  run psql --tuples-only --no-align -c "${QUERY}"
+  run psql --dbname="$PPM_DATABASE" --tuples-only --no-align -c "${QUERY}"
 
   assert_success
   assert_output f