JET test FIX.

Author: mabuni1998

src/basis.jl

@@ -805,6 +805,7 @@ function get_nsteps(basis::CompositeBasis)
             return get_nsteps(b)
         end
     end
+    return 0
 end
 
 """
@@ -818,14 +819,15 @@ function get_dt(basis::WaveguideBasis)
     basis.dt
 end
 function get_dt(basis::Basis)
-    0
+    0.0
 end
 function get_dt(basis::CompositeBasis)
     for b in basis.bases
-        if get_dt(b) != 0
+        if get_dt(b) != 0.0
             return get_dt(b)
         end
     end
+    return 0.0
 end
 
 """

src/solver.jl

@@ -108,10 +108,6 @@ end
 See documentation for [`waveguide_evolution`](@ref) on how to define `fout`. J should be a list of collapse operators following documentation of [`timeevolution.mcwf_dynamic`](https://docs.qojulia.org/api/#QuantumOptics.timeevolution.mcwf_dynamic). 
 """
 function fast_unitary(times_eval,psi,H;order=2,fout=nothing)
-    if fout !== nothing
-        fout_type = QuantumOptics.pure_inference(fout)
-        output_container = Array{fout_type}(undef,length(times_eval))
-    end
     isapprox(norm(psi),1,rtol=10^(-6)) || @warn "Initial waveguidestate is not normalized. Consider passing norm=true to the state generation function."
     dt = get_dt(H.basis_l)
     U = generate_unitary(H,dt,order)

test/test_jet.jl

@@ -1,25 +1,10 @@
-using WaveguideQED, JET
-
-using JET: ReportPass, BasicPass, InferenceErrorReport, UncaughtExceptionReport
-
-# Custom report pass that ignores `UncaughtExceptionReport`
-# Too coarse currently, but it serves to ignore the various
-# "may throw" messages for runtime errors we raise on purpose
-# (mostly on malformed user input)
-struct MayThrowIsOk <: ReportPass end
-
-# ignores `UncaughtExceptionReport` analyzed by `JETAnalyzer`
-(::MayThrowIsOk)(::Type{UncaughtExceptionReport}, @nospecialize(_...)) = return
-
-# forward to `BasicPass` for everything else
-function (::MayThrowIsOk)(report_type::Type{<:InferenceErrorReport}, @nospecialize(args...))
-    BasicPass()(report_type, args...)
-end
-
-rep = report_package("WaveguideQED";
-    report_pass=MayThrowIsOk(), # TODO have something more fine grained than a generic "do not care about thrown errors"
-    ignored_modules=(
-        ))
-
-@show rep
-@test_broken length(JET.get_reports(rep)) == 0 # TODO JET reports issues
+@testset "JET checks" begin
+    using JET
+    using Test
+    using WaveguideQED
+
+    rep = JET.report_package(WaveguideQED, target_defined_modules = true)
+    println(rep)
+    @testset length(JET.get_reports(rep)) <= 10
+    @test_broken length(JET.get_reports(rep)) == 0
+end