Skip to content

[Feature Request] Adafruit BLE UART Friend support #10674

@kanru

Description

@kanru

Feature Request Type

  • Core functionality
  • Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
  • Alteration (enhancement/optimization) of existing feature(s)
  • New behavior

Description

Hi, I'm working on a qmk fork of the YANG's HHKB BLE mod. The controller uses the MDBT40 module and Adafruit BLE UART Friend's firmware. I have a working version using the UART protocol here: https://github.com/kanru/qmk_firmware/blob/hhkb_yang/tmk_core/protocol/lufa/adafruit_ble_uart.c

The UART version implements all of the interface defined in adafruit_ble.h so I didn't have to change other places to enable send keys or outputselect. As you see most of the AT commands are the same and the sequence is the same, just the transport is different and some additional functionality for battery service.

I would like open a pull request to merge this code but I want to discuss how the project would like to structure the code first. I'm aware there is already a pull request #8982 but I think a simpler approach would be making an abstract interface for the AT command transport layer and implement an adafruit ble driver on top of it. What do you think? Any suggestion about the file path and directory structure?

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementhelp wantedstaleIssues or pull requests that have become inactive without resolution.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions