Skip to content

Change Newick validation from sniff to validate #247

@ChrisKeefe

Description

@ChrisKeefe

Improvement Description
Proper validation, possibly including empty-tree detection, could better protect users from passing bad phylogenies.

Current Behavior
NewickFormat uses a sniff pulled from skbio. If this is the sniffer linked in References, it catches empty trees, but only checks 100 tokens.

Proposed Behavior
A more comprehensive validation.

Questions

  1. Is the skbio sniffer already doing what we need?
  2. Is a full-length validation reasonable, timewise?

References

  1. This might be our sniffer?
  2. Newick overview

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions