Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cmake minimum version to 3.23 #60048

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Bump cmake minimum version to 3.23 #60048

merged 1 commit into from
Jan 6, 2025

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Jan 4, 2025

This allows us to use FILE_SETs to avoid installing header files in some scenarios (e.g. mac packages).
There are other options as well, but I wonder if this requirement would be acceptable.

@github-actions github-actions bot added this to the 3.42.0 milestone Jan 4, 2025
Copy link

github-actions bot commented Jan 4, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit e64e545)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit e64e545)

@troopa81 troopa81 merged commit 61c10d4 into qgis:master Jan 6, 2025
35 checks passed
@m-kuhn m-kuhn deleted the bump_cmake branch January 6, 2025 09:25
@jef-n
Copy link
Member

jef-n commented Jan 21, 2025

Breaks builds on jammy which has 3.22.1

@Alex-Kent
Copy link
Contributor

Alex-Kent commented Mar 16, 2025

As jef-n noted increasing the minimum CMake version for 3.23.0 breaks builds on Ubuntu 22.04 LTS Jammy which has 3.22.1. In practice the current QGIS master branch from Git builds fine if the minimum required CMake version is manually changed to 3.22.0. In other words, FILE_SET or other later features might be present in the CMakeFiles but those features don't appear to be used on the code path used for Ubuntu builds. In particular, the FILE_SET feature (the stated reason for increasing the required CMake version) doesn't appear to be used anywhere in the CMake files.

I suggest reverting this back to its previous value. If and when a CMake feature is needed that is only available via newer CMake versions then the minimum required version can be increased. Until that time the required CMake version should remain at the lower number. In other words, the requirement should match what is actually required to build QGIS using CMake, not the version needed for features that might be nice to use in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants