Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): remove repeated code in package config #43

Open
qascade opened this issue May 19, 2023 · 9 comments
Open

refactor(config): remove repeated code in package config #43

qascade opened this issue May 19, 2023 · 9 comments
Assignees

Comments

@qascade
Copy link
Owner

qascade commented May 19, 2023

Description

While writing the config parser. I had to give in to some level of redundancy for the sake of other high priorities. I want that to be fixed. I want to refactor and refine the config parser and remove unnecessary redundancies.

@qascade qascade added enhancement New feature or request beginner-friendly labels May 19, 2023
@i-am-yuvi
Copy link

Assign this to me, I am very much familiar with config files in Go

@qascade
Copy link
Owner Author

qascade commented May 21, 2023

Hey, @i-am-yuvi, assigning this to you. Please make sure that you don't change the structures/types of the abstractions defined in the package config. Also this is not a breaking change, so all the parsing tests should pass. Also extend the TestConfig() function to have more stricter checks as per #35

@i-am-yuvi
Copy link

Surely 🚀

@qascade qascade changed the title refactor: remove repeated code in package config refactor(config): remove repeated code in package config May 21, 2023
@qascade
Copy link
Owner Author

qascade commented May 21, 2023

@i-am-yuvi Please name the branch refactor.redundancy_removal_config

@i-am-yuvi
Copy link

Sure

@qascade
Copy link
Owner Author

qascade commented May 26, 2023

@i-am-yuvi Any progress on the issue? As per policy, I will have to unassign this issue on 3 days of inactivity.

@i-am-yuvi
Copy link

Yes I am working on it

@shrey-a-gupta
Copy link

Hi @qascade , I am new to GO language, however I want to learn and contribute to this project and would want to work on this Issue. May you guide me in this issue and assign ?

@qascade
Copy link
Owner Author

qascade commented Jun 19, 2023

@shrey-a-gupta you can email me at [email protected], we will connect of required. Thanks for taking interest in my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants