Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): error message on wrong yaml input. #28

Open
qascade opened this issue May 4, 2023 · 14 comments
Open

fix(config): error message on wrong yaml input. #28

qascade opened this issue May 4, 2023 · 14 comments
Assignees
Labels

Comments

@qascade
Copy link
Owner

qascade commented May 4, 2023

Description

There is a code in the ParseSpec() function that outputs a better error message if there is an error in input yaml but for some reason, the proper error message is not propagating back.

@qascade qascade added bug Something isn't working good first issue Good for newcomers beginner-friendly labels May 4, 2023
@shraddha761
Copy link

Want to contribute on this issue request to assign me this issue

@qascade
Copy link
Owner Author

qascade commented May 20, 2023

Hey, @shraddha761 thanks for your enthusiasm. Currently no issues are being assigned until GSSoC Mentors are onboarded. That should happen by EOD. Then I will start assigning the issues. You can start looking at the code and the spec docs and try to understand the project in the meanwhile.

@qascade
Copy link
Owner Author

qascade commented May 21, 2023

Hey, @shraddha761 assigning this issue to you.

@qascade qascade changed the title bug: fix error message on wrong yaml input. fix(config): error message on wrong yaml input. May 21, 2023
@shraddha761
Copy link

image
hey @qascade what to change in the following line

@qascade
Copy link
Owner Author

qascade commented May 21, 2023

@shraddha761 To fix this issue, you introduce an error in yaml. Then, you run TestConfig() function. After that the code should return err3 in the above code. That's not happening. Make any necessary changes that do not break any present functionality but gives a proper meaningful error if things go wrong.

@shraddha761
Copy link

@qascade I am not familiar with Go and yml file will you please explain little bit about the changes to be done

@qascade
Copy link
Owner Author

qascade commented May 21, 2023

@shraddha761 Oh no worries, You should probably get familiar with Go and Yaml first. Added a beginners section in GSSoC_Guidelines.md. Please check that out.

@qascade
Copy link
Owner Author

qascade commented May 21, 2023

The dcr binary runs a folder containing yaml files and runs a service on them. You should try to understand what the project is at a high level before proceeding to change anything. You may understand that after watching my video and reading the spec doc.

@qascade
Copy link
Owner Author

qascade commented May 22, 2023

Hey @shraddha761, Any progress on the PR?

@shraddha761
Copy link

@qascade I tried to do some changes but didn't get the proper output

@qascade
Copy link
Owner Author

qascade commented May 22, 2023

@shraddha761 Let's continue this on discord.

@shraddha761
Copy link

@qascade Yahh sure

@qascade
Copy link
Owner Author

qascade commented May 22, 2023

Please come by the #dcr channel @shraddha761

@sagnik-p
Copy link

sagnik-p commented Jun 9, 2023

This issue has been inactive for a long time
Is this resolved?
If not, I would like to work on this issue
Please assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants