Skip to content

Commit 3dbdf4a

Browse files
TroyGardenfacebook-github-bot
authored andcommitted
remove ROCM arch from binary validation (#3048)
Summary: Pull Request resolved: #3048 # context * torchrec github actions re-uses lots of workflows from pytorch-test-infra * in the build-wheels-linux it disables rocm ``` generate-matrix: uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main with: package-type: wheel os: linux test-infra-repository: pytorch/test-infra test-infra-ref: main with-rocm: false ``` * but in the validate-binaries it uses default, which generates rocm arch for testing ``` validate-binaries: uses: pytorch/test-infra/.github/workflows/validate-domain-library.yml@main with: package_type: "wheel" os: "linux" channel: ${{ inputs.channel }} repository: "pytorch/torchrec" smoke_test: "source ./.github/scripts/validate_binaries.sh" with_cuda: enable with_rocm: false <---- this line is added by this diff ``` * since there's no ROCM support so the validate_binaries.sh script has to do an early return ``` if [[ ${MATRIX_GPU_ARCH_TYPE} = 'rocm' ]]; then echo "We don't support rocm" exit 0 fi ``` WARNING: although the validate-binaries.sh script does early return but it still consume github runner to set up the docker and so. Pure waste of resources. * this entire thing is unnecessary if we just exclude ROCM arch in the config Reviewed By: aporialiao Differential Revision: D76107773 fbshipit-source-id: fe44f0c5306ed503a3c92d9d741b49ec7103e67e
1 parent 7236a1a commit 3dbdf4a

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

.github/scripts/validate_binaries.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ conda run -n build_binary python --version
2222
# installation instructions on following page
2323
# https://github.com/pytorch/torchrec#installations
2424

25-
if [[ ${MATRIX_GPU_ARCH_TYPE} = 'rocm' ]]; then
26-
echo "We don't support rocm"
27-
exit 0
28-
fi
2925

3026
# figure out CUDA VERSION
3127
if [[ ${MATRIX_GPU_ARCH_TYPE} = 'cuda' ]]; then

.github/workflows/validate-binaries.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,4 @@ jobs:
3939
repository: "pytorch/torchrec"
4040
smoke_test: "source ./.github/scripts/validate_binaries.sh"
4141
with_cuda: enable
42+
with_rocm: false

0 commit comments

Comments
 (0)