diff --git a/torchci/components/benchmark/v3/components/common/SelectionDialog.tsx b/torchci/components/benchmark/v3/components/common/SelectionDialog.tsx index ec440aff59..4a9d4c2bf3 100644 --- a/torchci/components/benchmark/v3/components/common/SelectionDialog.tsx +++ b/torchci/components/benchmark/v3/components/common/SelectionDialog.tsx @@ -7,7 +7,7 @@ import { } from "@mui/material"; import { Typography } from "@mui/material"; -import { resolveComponent } from "../../configs/configRegistration"; +import { resolveComponent } from "../../configs/utils/configComponentRegistration"; import { RawTimeSeriesPoint } from "../dataRender/components/benchmarkTimeSeries/helper"; export interface TimeSeriesChartDialogContentProps { diff --git a/torchci/components/benchmark/v3/configs/configBook.tsx b/torchci/components/benchmark/v3/configs/configBook.tsx index 7dc2e29fca..087a529faf 100644 --- a/torchci/components/benchmark/v3/configs/configBook.tsx +++ b/torchci/components/benchmark/v3/configs/configBook.tsx @@ -1,9 +1,12 @@ import { DefaultFanoutRenderContent } from "../components/dataRender/fanout/defaultFanoutRenderContent"; -import { NotFoundComponent, resolveComponent } from "./configRegistration"; import { CompilerPrecomputeBenchmarkUIConfig, COMPILTER_PRECOMPUTE_BENCHMARK_ID, } from "./teams/compilers/config"; +import { + NotFoundComponent, + resolveComponent, +} from "./utils/configComponentRegistration"; import { DataBinding, DataBindingConfig, diff --git a/torchci/components/benchmark/v3/configs/configRegistration.tsx b/torchci/components/benchmark/v3/configs/utils/configComponentRegistration.tsx similarity index 50% rename from torchci/components/benchmark/v3/configs/configRegistration.tsx rename to torchci/components/benchmark/v3/configs/utils/configComponentRegistration.tsx index fbd177733d..f1d23bff1c 100644 --- a/torchci/components/benchmark/v3/configs/configRegistration.tsx +++ b/torchci/components/benchmark/v3/configs/utils/configComponentRegistration.tsx @@ -1,19 +1,12 @@ import React from "react"; -import { CompilerPrecomputeConfirmDialogContent } from "./teams/compilers/CompilerPrecomputeConfirmDialogContent"; -import { CompilerSearchBarDropdowns } from "./teams/compilers/CompilerSearchBarDropdowns"; -import { compilerQueryParameterConverter } from "./teams/compilers/config"; -import { QueryParameterConverter } from "./utils/dataBindingRegistration"; +import { CompilerPrecomputeConfirmDialogContent } from "../teams/compilers/CompilerPrecomputeConfirmDialogContent"; +import { CompilerSearchBarDropdowns } from "../teams/compilers/CompilerSearchBarDropdowns"; export const COMPONENT_REGISTRY: Record> = { CompilerSearchBarDropdowns, CompilerPrecomputeConfirmDialogContent, }; -// register converters for data params, this is -export const CONVERTER_REGISTRY: Record = { - compilerQueryParameterConverter, -}; - export function resolveComponent( name: string | undefined | null ): React.ComponentType | undefined { diff --git a/torchci/components/benchmark/v3/configs/utils/dataBindingRegistration.tsx b/torchci/components/benchmark/v3/configs/utils/dataBindingRegistration.tsx index c397fb383a..c83c3caf7b 100644 --- a/torchci/components/benchmark/v3/configs/utils/dataBindingRegistration.tsx +++ b/torchci/components/benchmark/v3/configs/utils/dataBindingRegistration.tsx @@ -1,8 +1,11 @@ import dayjs, { Dayjs } from "dayjs"; import { TimeRange } from "lib/benchmark/store/benchmark_regression_store"; import DefaultMetricsDropdowns from "../../components/benchmarkSideBar/components/DefaultSideBarMetricsDropdowns"; -import { NotFoundComponent, resolveComponent } from "../configRegistration"; import { compilerQueryParameterConverter } from "../teams/compilers/config"; +import { + NotFoundComponent, + resolveComponent, +} from "./configComponentRegistration"; export const MIN_SAMPLING_THRESHOLD = 2; export type DataBindingConfig = {