Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected row not (visibly) highlighted with Solarized Dark colorscheme #43

Closed
stefankreutz opened this issue Jan 12, 2025 · 10 comments
Closed

Comments

@stefankreutz
Copy link

I can't see which row is selected when using the Solazired Dark colorscheme because the DarkGray highlight background is indistinguishable from the Solarized background color.

There was a similar issue #30 with the Solarized Light colorscheme, which was fixed in PR #32.

I would like to see a highlight symbol such as a leading arrow because that should work for everybody, regardless of the colorscheme. I'll submit PR shortly.

@pythops
Copy link
Owner

pythops commented Jan 12, 2025

Can you share a screenshot ?

@stefankreutz
Copy link
Author

Here is a screenshot. The first paired device should be highlighted.

image

@pythops
Copy link
Owner

pythops commented Jan 12, 2025

yeah I can add a highlight symbol for the selected device like the adapter section

@stefankreutz
Copy link
Author

That would be great!

Here is a corresponding PR #44. Feel free to merge or discard.

@pythops
Copy link
Owner

pythops commented Jan 12, 2025

hahahah we just made it at the same time
#45

@pythops
Copy link
Owner

pythops commented Jan 12, 2025

I added it to the other section as well. If you don't mind we can keep my PR :)

@stefankreutz
Copy link
Author

Of course. Thank you!

@pythops
Copy link
Owner

pythops commented Jan 12, 2025

if you can approve it then I will merge it :)

@stefankreutz
Copy link
Author

I've tested I locally and am happy with it. Is there any box I should tick to approve? :)

@pythops
Copy link
Owner

pythops commented Jan 12, 2025

no need, merged, enjoy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants