fix argument processing in mkvirtualenv

dhellmann · dhellmann · commit 442814081134 · 2009-03-06T12:37:48.000-05:00
diff --git a/README b/README
@@ -69,6 +69,10 @@ For more details, refer to the column I wrote for the May 2008 issue of Python M
 =======
 Updates
 =======
+
+1.8.1
+  - Corrected a problem with change to mkvirtualenv that lead to release 1.8 by using an alternate fix proposed by James in comments on release 1.4.
+
 1.8
   - Fix for processing the argument list in mkvirtualenv from jorgevargas (BitBucket issue #1)
 
diff --git a/virtualenvwrapper_bashrc b/virtualenvwrapper_bashrc
@@ -64,9 +64,10 @@ function verify_active_environment () {
 # (where the options are passed directly to virtualenv)
 #
 function mkvirtualenv () {
+    eval "envname=\$$#"
     verify_workon_home
-    (cd "$WORKON_HOME"; virtualenv "$@") 
-    workon "$_"
+    (cd "$WORKON_HOME"; virtualenv "$@")
+    workon "$envname"
 }
 
 # Remove an environment, in the WORKON_HOME.

Original file line number	Diff line number	Diff line change
`@@ -64,9 +64,10 @@ function verify_active_environment () {`
`64`	`64`	`# (where the options are passed directly to virtualenv)`
`65`	`65`	`#`
`66`	`66`	`function mkvirtualenv () {`
	`67`	`+ eval "envname=\$$#"`
`67`	`68`	`verify_workon_home`
`68`		`- (cd "$WORKON_HOME"; virtualenv "$@")`
`69`		`- workon "$_"`
	`69`	`+ (cd "$WORKON_HOME"; virtualenv "$@")`
	`70`	`+ workon "$envname"`
`70`	`71`	`}`
`71`	`72`
`72`	`73`	`# Remove an environment, in the WORKON_HOME.`