Add tests for sdist tar.

Author: amjith

metadata_please/sdist.py

@@ -30,11 +30,11 @@ def from_zip_sdist(zf: ZipFile) -> bytes:
 def basic_metadata_from_zip_sdist(zf: ZipFile) -> BasicMetadata:
     requires = [f for f in zf.namelist() if f.endswith("/requires.txt")]
     requires.sort(key=len)
-    if not requires:
-        return BasicMetadata((), frozenset(), "-")
-
-    requires_data = zf.read(requires[0])
-    assert requires_data is not None
+    if requires:
+        requires_data = zf.read(requires[0])
+        assert requires_data is not None
+    else:
+        requires_data = b""
 
     pkg_info = next(f for f in zf.namelist() if f.endswith("/PKG-INFO"))
     pkg_info_data = zf.read(pkg_info)
@@ -71,17 +71,17 @@ def basic_metadata_from_tar_sdist(tf: TarFile) -> BasicMetadata:
     # XXX Why do ZipFile and TarFile not have a common interface ?!
     requires = [f for f in tf.getnames() if f.endswith("/requires.txt")]
     requires.sort(key=len)
-    if not requires:
-        return BasicMetadata((), frozenset())
-
-    requires_fo = tf.extractfile(requires[0])
-    assert requires_fo is not None
+    if requires:
+        requires_fo = tf.extractfile(requires[0])
+        assert requires_fo is not None
+    else:
+        requires_fo = b""
 
     pkg_info = next(f for f in tf.getnames() if f.endswith("/PKG-INFO"))
 
     pkg_info_fo = tf.extractfile(pkg_info)
     assert pkg_info_fo is not None
 
     return BasicMetadata.from_sdist_pkg_info_and_requires(
-        pkg_info_fo.read(), requires_fo.read()
+        pkg_info_fo.read(), requires_fo and requires_fo.read()
     )

metadata_please/tests/sdist.py

@@ -15,6 +15,7 @@ def test_requires_as_expected(self) -> None:
         z = MemoryZipFile(
             {
                 "foo/__init__.py": b"",
+                "foo.egg-info/PKG-INFO": b"\n",
                 "foo.egg-info/requires.txt": b"""\
 a
 [e]
@@ -36,6 +37,7 @@ def test_basic_metadata(self) -> None:
         z = MemoryZipFile(
             {
                 "foo/__init__.py": b"",
+                "foo.egg-info/PKG-INFO": b"\n",
                 "foo.egg-info/requires.txt": b"""\
 a
 [e]
@@ -68,6 +70,7 @@ def test_basic_metadata_absl_py_09(self) -> None:
         z = MemoryZipFile(
             {
                 "foo/__init__.py": b"",
+                "foo.egg-info/PKG-INFO": b"\n",
                 "foo.egg-info/requires.txt": b"""\
 six
 
@@ -94,7 +97,7 @@ def test_basic_metadata_absl_py_09(self) -> None:
 class TarSdistTest(unittest.TestCase):
     def test_requires_as_expected(self) -> None:
         t = MemoryTarFile(
-            ["foo.egg-info/requires.txt", "foo/__init__.py"],
+            ["foo.egg-info/PKG-INFO", "foo.egg-info/requires.txt", "foo/__init__.py"],
             read_value=b"""\
 a
 [e]
@@ -113,7 +116,7 @@ def test_requires_as_expected(self) -> None:
 
     def test_basic_metadata(self) -> None:
         t = MemoryTarFile(
-            ["foo.egg-info/requires.txt", "foo/__init__.py"],
+            ["foo.egg-info/PKG-INFO", "foo.egg-info/requires.txt", "foo/__init__.py"],
             read_value=b"""\
 a
 [e]
@@ -126,3 +129,18 @@ def test_basic_metadata(self) -> None:
             bm.reqs,
         )
         self.assertEqual({"e"}, bm.provides_extra)
+
+    def test_metadata_fields_from_tar_sdist(self) -> None:
+        t = MemoryTarFile(
+            ["foo.egg-info/PKG-INFO", "foo/__init__.py"],
+            read_value=b"""Requires-Dist: foo\nVersion: 1.2.58\nSummary: Some Summary\nHome-page: http://example.com\nAuthor: Chicken\nAuthor-email: [email protected]\nKeywords: farm,animals\nRequires-Python: >=3.6\nDescription-Content-Type: text/markdown\n""",
+        )
+        bm = basic_metadata_from_tar_sdist(t)  # type: ignore
+        self.assertEqual("1.2.58", bm.version)
+        self.assertEqual("Some Summary", bm.summary)
+        self.assertEqual("http://example.com", bm.url)
+        self.assertEqual("Chicken", bm.author)
+        self.assertEqual("[email protected]", bm.author_email)
+        self.assertEqual("farm,animals", bm.keywords)
+        self.assertEqual("text/markdown", bm.long_description_content_type)
+        self.assertEqual(None, bm.description)