Allow more ruff rules. (#414)

Author: tobiasraabe

.github/workflows/main.yml

@@ -30,7 +30,7 @@ jobs:
         python-version: ['3.8', '3.9', '3.10', '3.11']
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: mamba-org/setup-micromamba@v1
         with:
           environment-name: gha-testing

.github/workflows/publish-to-pypi.yml

@@ -7,7 +7,7 @@ jobs:
     name: Build and publish Python 🐍 distributions 📦 to PyPI
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
 
     - name: Set up Python 3.8
       uses: actions/setup-python@v4

.github/workflows/update-plugin-list.yml

@@ -19,7 +19,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

docs/source/changes.md

@@ -30,6 +30,7 @@ releases are available on [PyPI](https://pypi.org/project/pytask) and
 - {pull}`410` allows to pass functions to `PythonNode(hash=...)`.
 - {pull}`412` adds protocols for tasks.
 - {pull}`413` removes scripts to generate `.svg`s.
+- {pull}`414` allow more ruff rules.
 
 ## 0.3.2 - 2023-06-07
 

docs/source/conf.py

@@ -7,8 +7,10 @@
 from __future__ import annotations
 
 from importlib.metadata import version
+from typing import TYPE_CHECKING
 
-import sphinx
+if TYPE_CHECKING:
+    import sphinx
 
 
 # -- Project information ---------------------------------------------------------------

environment.yml

@@ -15,7 +15,7 @@ dependencies:
   - click
   - click-default-group
   - networkx >=2.4
-  - pluggy
+  - pluggy >=1.0.0
   - optree >=0.9
   - rich
   - sqlalchemy >=1.4.36

pyproject.toml

@@ -33,8 +33,8 @@ target-version = "py38"
 select = ["ALL"]
 fix = true
 extend-ignore = [
+    "I",  # ignore isort
     "TRY",  # ignore tryceratops.
-    "TCH",  # ignore non-guarded type imports.
     # Numpy docstyle
     "D107",
     "D203",
@@ -46,25 +46,17 @@ extend-ignore = [
     "D416",
     "D417",
     # Others.
-    "D404",  # Do not start module docstring with "This".
-    "RET504",  # unnecessary variable assignment before return.
     "S101",  # raise errors for asserts.
-    "B905",  # strict parameter for zip that was implemented in py310.
-    "I",  # ignore isort
     "ANN101",  # type annotating self
     "ANN102",  # type annotating cls
     "FBT",  # flake8-boolean-trap
-    "EM",  # flake8-errmsg
     "ANN401",  # flake8-annotate typing.Any
     "PD",  # pandas-vet
     "COM812",  # trailing comma missing, but black takes care of that
     "D401",  # imperative mood for first line. too many false-positives.
     "SLF001",  # access private members.
     "S603",
     "S607",
-    # Temporary
-    "TD002",
-    "TD003",
 ]
 
 
@@ -73,7 +65,7 @@ extend-ignore = [
 "src/_pytask/hookspecs.py" = ["ARG001"]
 "src/_pytask/outcomes.py" = ["N818"]
 "tests/test_capture.py" = ["T201", "PT011"]
-"tests/*" = ["D", "ANN", "PLR2004"]
+"tests/*" = ["D", "ANN", "PLR2004", "S101"]
 "scripts/*" = ["D", "INP001"]
 "docs/source/conf.py" = ["D401", "INP001"]
 

scripts/update_plugin_list.py

@@ -81,8 +81,7 @@ def _escape_rst(text: str) -> str:
         .replace(">", "\\>")
         .replace("`", "\\`")
     )
-    text = re.sub(r"_\b", "", text)
-    return text
+    return re.sub(r"_\b", "", text)
 
 
 def _iter_plugins() -> Generator[dict[str, str], None, None]:  # noqa: C901

setup.cfg

@@ -36,7 +36,7 @@ install_requires =
     networkx>=2.4
     optree>=0.9
     packaging
-    pluggy
+    pluggy>=1.0.0
     rich
     sqlalchemy>=1.4.36
     tomli>=1.0.0

src/_pytask/_inspect.py

@@ -99,13 +99,15 @@ def get_annotations(  # noqa: C901, PLR0912, PLR0915
             obj_locals = None
             unwrap = obj
         else:
-            raise TypeError(f"{obj!r} is not a module, class, or callable.")
+            msg = f"{obj!r} is not a module, class, or callable."
+            raise TypeError(msg)
 
         if ann is None:
             return {}
 
         if not isinstance(ann, dict):
-            raise ValueError(f"{obj!r}.__annotations__ is neither a dict nor None")
+            msg = f"{obj!r}.__annotations__ is neither a dict nor None"
+            raise ValueError(msg)
 
         if not ann:
             return {}
@@ -131,10 +133,9 @@ def get_annotations(  # noqa: C901, PLR0912, PLR0915
             locals = obj_locals  # noqa: A001
 
         eval_func = eval
-        return_value = {
+        return {
             key: value
             if not isinstance(value, str)
             else eval_func(value, globals, locals)
             for key, value in ann.items()
         }
-        return return_value