Fix bug when passing no path on the command line. (#337)

Author: tobiasraabe

docs/source/changes.md

@@ -5,7 +5,12 @@ chronological order. Releases follow [semantic versioning](https://semver.org/)
 releases are available on [PyPI](https://pypi.org/project/pytask) and
 [Anaconda.org](https://anaconda.org/conda-forge/pytask).
 
-## 0.3.0 - 2022-12-xx
+## 0.3.1 - 2023-12-25
+
+- {pull}`337` fixes fallback to root path when `pytask collect` or `pytask clean` are
+  used without paths.
+
+## 0.3.0 - 2023-12-22
 
 - {pull}`313` refactors the configuration. INI configurations are no longer supported.
 - {pull}`326` fixes the badge for status of the workflow.

src/_pytask/config_utils.py

@@ -32,7 +32,7 @@ def set_defaults_from_config(
         context.params["config"] = value
         context.params["root"] = context.params["config"].parent
     else:
-        if context.params["paths"] is None:
+        if not context.params["paths"]:
             context.params["paths"] = (Path.cwd(),)
 
         context.params["paths"] = parse_paths(context.params["paths"])

tests/test_clean.py

@@ -1,7 +1,9 @@
 from __future__ import annotations
 
+import os
 import subprocess
 import textwrap
+from pathlib import Path
 
 import pytest
 from _pytask.git import init_repo
@@ -54,6 +56,19 @@ def task_write_text(produces):
     return tmp_path
 
 
+@pytest.mark.end_to_end()
+def test_clean_with_auto_collect(project, runner):
+    cwd = Path.cwd()
+    os.chdir(project)
+    result = runner.invoke(cli, ["clean"])
+    os.chdir(cwd)
+
+    assert result.exit_code == ExitCode.OK
+    text_without_linebreaks = result.output.replace("\n", "")
+    assert "to_be_deleted_file_1.txt" in text_without_linebreaks
+    assert "to_be_deleted_file_2.txt" in text_without_linebreaks
+
+
 @pytest.mark.end_to_end()
 @pytest.mark.parametrize("flag", ["-e", "--exclude"])
 @pytest.mark.parametrize("pattern", ["*_1.txt", "to_be_deleted_file_[1]*"])

tests/test_collect_command.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import os
 import textwrap
 from pathlib import Path
 
@@ -49,6 +50,32 @@ def task_example():
     assert "out.txt>" in captured
 
 
+@pytest.mark.end_to_end()
+def test_collect_task_in_root_dir(runner, tmp_path):
+    source = """
+    import pytask
+
+    @pytask.mark.depends_on("in.txt")
+    @pytask.mark.produces("out.txt")
+    def task_example():
+        pass
+    """
+    tmp_path.joinpath("task_module.py").write_text(textwrap.dedent(source))
+    tmp_path.joinpath("in.txt").touch()
+
+    cwd = Path.cwd()
+    os.chdir(tmp_path)
+    result = runner.invoke(cli, ["collect"])
+    os.chdir(cwd)
+
+    assert result.exit_code == ExitCode.OK
+    captured = result.output.replace("\n", "").replace(" ", "")
+    assert "<Module" in captured
+    assert "task_module.py>" in captured
+    assert "<Function" in captured
+    assert "task_example>" in captured
+
+
 @pytest.mark.end_to_end()
 def test_collect_parametrized_tasks(runner, tmp_path):
     source = """

tests/test_execute.py

@@ -1,9 +1,11 @@
 from __future__ import annotations
 
+import os
 import re
 import subprocess
 import sys
 import textwrap
+from pathlib import Path
 
 import pytest
 from _pytask.exceptions import NodeNotFoundError
@@ -20,6 +22,17 @@ def test_python_m_pytask(tmp_path):
     subprocess.run(["python", "-m", "pytask", tmp_path.as_posix()], check=True)
 
 
+@pytest.mark.end_to_end()
+def test_execute_w_autocollect(runner, tmp_path):
+    tmp_path.joinpath("task_module.py").write_text("def task_example(): pass")
+    cwd = Path.cwd()
+    os.chdir(tmp_path)
+    result = runner.invoke(cli)
+    os.chdir(cwd)
+    assert result.exit_code == ExitCode.OK
+    assert "1  Succeeded" in result.output
+
+
 @pytest.mark.end_to_end()
 def test_task_did_not_produce_node(tmp_path):
     source = """