Add refurb to pre-commit hooks. (#311)

Author: tobiasraabe

.pre-commit-config.yaml

@@ -72,6 +72,12 @@ repos:
             pydocstyle,
             Pygments,
         ]
+-   repo: https://github.com/dosisod/refurb
+    rev: v1.5.0
+    hooks:
+    -   id: refurb
+        args: [--ignore, FURB126]
+        language_version: python3.10
 -   repo: https://github.com/executablebooks/mdformat
     rev: 0.7.16
     hooks:

src/_pytask/clean.py

@@ -223,7 +223,7 @@ def _collect_all_paths_known_to_pytask(session: Session) -> set[Path]:
 def _yield_paths_from_task(task: Task) -> Generator[Path, None, None]:
     """Yield all paths attached to a task."""
     yield task.path
-    for attribute in ["depends_on", "produces"]:
+    for attribute in ("depends_on", "produces"):
         for node in tree_just_yield(getattr(task, attribute)):
             if hasattr(node, "path") and isinstance(node.path, Path):
                 yield node.path

src/_pytask/click.py

@@ -118,7 +118,7 @@ def print_options(group_or_command: click.Command | DefaultGroup, ctx: Any) -> N
         elif len(param.opts) == 2:
             opt1 = highlighter(param.opts[0])
             opt2 = highlighter(param.opts[1])
-        elif len(param.opts) == 1 and len(param.secondary_opts) == 1:
+        elif len(param.opts) == 1 == len(param.secondary_opts):
             opt1 = Text("")
             opt2 = highlighter(param.opts[0] + "/" + param.secondary_opts[0])
         else:

src/_pytask/config.py

@@ -284,7 +284,7 @@ def _find_project_root_and_config(paths: list[Path]) -> tuple[Path, Path]:
     parent_directories = [common_ancestor] + list(common_ancestor.parents)
 
     for parent in parent_directories:
-        for config_name in ["pyproject.toml", "pytask.ini", "tox.ini", "setup.cfg"]:
+        for config_name in ("pyproject.toml", "pytask.ini", "tox.ini", "setup.cfg"):
 
             path = parent.joinpath(config_name)
 

src/_pytask/config_utils.py

@@ -18,7 +18,7 @@ def parse_click_choice(
     value_to_name = {enum_[name].value: name for name in enum_.__members__}
 
     def _parse(x: Enum | str | None) -> Enum | None:
-        if x in [None, "None", "none"]:
+        if x in (None, "None", "none"):
             out = None
         elif isinstance(x, str) and x in value_to_name:
             out = enum_[value_to_name[x]]

src/_pytask/debugging.py

@@ -97,7 +97,7 @@ def _pdbcls_callback(x: str | None) -> tuple[str, str] | None:
     """Validate the debugger class string passed to pdbcls."""
     message = "'pdbcls' must be like IPython.terminal.debugger:TerminalPdb"
 
-    if x in [None, "None", "none"]:
+    if x in (None, "None", "none"):
         return None
     elif isinstance(x, str):
         if len(x.split(":")) != 2:

src/_pytask/live.py

@@ -59,7 +59,7 @@ def pytask_parse_config(
 
 def _parse_n_entries_in_table(value: int | str | None) -> int:
     """Parse how many entries should be displayed in the table during the execution."""
-    if value in ["none", "None", None, ""]:
+    if value in ("none", "None", None, ""):
         out = None
     elif isinstance(value, int) and value >= 1:
         out = value

src/_pytask/logging.py

@@ -64,9 +64,9 @@ def pytask_parse_config(
         config_from_file,
         key="editor_url_scheme",
         default="file",
-        callback=lambda x: None if x in [None, "none", "None"] else str(x),
+        callback=lambda x: None if x in (None, "none", "None") else str(x),
     )
-    if config["editor_url_scheme"] not in ["no_link", "file"] and IS_WINDOWS_TERMINAL:
+    if config["editor_url_scheme"] not in ("no_link", "file") and IS_WINDOWS_TERMINAL:
         config["editor_url_scheme"] = "file"
         warnings.warn(
             "Windows Terminal does not support url schemes to applications, yet."
@@ -145,9 +145,9 @@ def _format_duration(duration: float) -> str:
     duration_tuples = _humanize_time(duration, "seconds", short_label=False)
 
     # Remove seconds if the execution lasted days or hours.
-    if duration_tuples[0][1] in ["day", "days", "hour", "hours"]:
+    if duration_tuples[0][1] in ("day", "days", "hour", "hours"):
         duration_tuples = [
-            i for i in duration_tuples if i[1] not in ["second", "seconds"]
+            i for i in duration_tuples if i[1] not in ("second", "seconds")
         ]
 
     formatted_duration = ", ".join([" ".join(map(str, i)) for i in duration_tuples])
@@ -177,7 +177,7 @@ def _humanize_time(
     """
     index = None
     for i, time_unit in enumerate(_TIME_UNITS):
-        if unit in [time_unit.singular, time_unit.plural]:
+        if unit in (time_unit.singular, time_unit.plural):
             index = i
             break
     else:

src/_pytask/mark/__init__.py

@@ -137,7 +137,7 @@ def _read_marker_mapping(x: dict[str, str] | str) -> dict[str, str]:
         mapping = {k.strip(): "" for k in x}
     elif isinstance(x, str):
         # Split by newlines and remove empty strings.
-        lines = filter(lambda i: bool(i), x.split("\n"))
+        lines = filter(bool, x.split("\n"))
         mapping = {}
         for line in lines:
             try:

src/_pytask/mark/structures.py

@@ -196,7 +196,7 @@ def __getattr__(self, name: str) -> MarkDecorator | Any:
                 if self.config["strict_markers"]:
                     raise ValueError(f"Unknown pytask.mark.{name}.")
                 # Raise a specific error for common misspellings of "parametrize".
-                if name in ["parameterize", "parametrise", "parameterise"]:
+                if name in ("parameterize", "parametrise", "parameterise"):
                     warnings.warn(f"Unknown {name!r} mark, did you mean 'parametrize'?")
 
                 warnings.warn(