Skip to content

Commit ca537c8

Browse files
authored
Remove status from pytask_execute_task_log_start. (#611)
1 parent fbb3bb2 commit ca537c8

File tree

4 files changed

+8
-13
lines changed

4 files changed

+8
-13
lines changed

docs/source/changes.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ releases are available on [PyPI](https://pypi.org/project/pytask) and
4949
- {pull}`605` improves checks and CI.
5050
- {pull}`609` allows a pending status for tasks. Useful for async backends implemented
5151
in pytask-parallel.
52+
- {pull}`611` removes the initial task execution status from
53+
`pytask_execute_task_log_start`.
5254

5355
## 0.4.7 - 2024-03-19
5456

src/_pytask/execute.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
from _pytask.exceptions import ExecutionError
2626
from _pytask.exceptions import NodeLoadError
2727
from _pytask.exceptions import NodeNotFoundError
28-
from _pytask.logging_utils import TaskExecutionStatus
2928
from _pytask.mark import Mark
3029
from _pytask.mark_utils import has_mark
3130
from _pytask.node_protocols import PNode
@@ -99,9 +98,7 @@ def pytask_execute_build(session: Session) -> bool | None:
9998
@hookimpl
10099
def pytask_execute_task_protocol(session: Session, task: PTask) -> ExecutionReport:
101100
"""Follow the protocol to execute each task."""
102-
session.hook.pytask_execute_task_log_start(
103-
session=session, task=task, status=TaskExecutionStatus.RUNNING
104-
)
101+
session.hook.pytask_execute_task_log_start(session=session, task=task)
105102
try:
106103
session.hook.pytask_execute_task_setup(session=session, task=task)
107104
session.hook.pytask_execute_task(session=session, task=task)

src/_pytask/hookspecs.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import click
1919
from pluggy import PluginManager
2020

21-
from _pytask.logging_utils import TaskExecutionStatus
2221
from _pytask.models import NodeInfo
2322
from _pytask.node_protocols import PNode
2423
from _pytask.node_protocols import PProvisionalNode
@@ -256,9 +255,7 @@ def pytask_execute_task_protocol(session: Session, task: PTask) -> ExecutionRepo
256255

257256

258257
@hookspec(firstresult=True)
259-
def pytask_execute_task_log_start(
260-
session: Session, task: PTask, status: TaskExecutionStatus
261-
) -> None:
258+
def pytask_execute_task_log_start(session: Session, task: PTask) -> None:
262259
"""Start logging of task execution.
263260
264261
This hook can be used to provide more verbose output during the execution.

src/_pytask/live.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@
2020

2121
from _pytask.console import console
2222
from _pytask.console import format_task_name
23+
from _pytask.logging_utils import TaskExecutionStatus
2324
from _pytask.outcomes import CollectionOutcome
2425
from _pytask.outcomes import TaskOutcome
2526
from _pytask.pluginmanager import hookimpl
2627

2728
if TYPE_CHECKING:
28-
from _pytask.logging_utils import TaskExecutionStatus
2929
from _pytask.node_protocols import PTask
3030
from _pytask.reports import CollectionReport
3131
from _pytask.reports import ExecutionReport
@@ -151,6 +151,7 @@ class LiveExecution:
151151
n_entries_in_table: int
152152
verbose: int
153153
editor_url_scheme: str
154+
initial_status: TaskExecutionStatus = TaskExecutionStatus.RUNNING
154155
sort_final_table: bool = False
155156
n_tasks: int | str = "x"
156157
_reports: list[_ReportEntry] = field(factory=list)
@@ -170,11 +171,9 @@ def pytask_execute_build(self) -> Generator[None, None, None]:
170171
return result
171172

172173
@hookimpl(tryfirst=True)
173-
def pytask_execute_task_log_start(
174-
self, task: PTask, status: TaskExecutionStatus
175-
) -> bool:
174+
def pytask_execute_task_log_start(self, task: PTask) -> bool:
176175
"""Mark a new task as running."""
177-
self.add_task(new_running_task=task, status=status)
176+
self.add_task(new_running_task=task, status=self.initial_status)
178177
return True
179178

180179
@hookimpl

0 commit comments

Comments
 (0)