Add more warnings:

Author: tobiasraabe

src/_pytask/collect.py

@@ -30,7 +30,7 @@
 from _pytask.mark import MarkGenerator
 from _pytask.mark_utils import get_all_marks
 from _pytask.mark_utils import has_mark
-from _pytask.node_protocols import PNode
+from _pytask.node_protocols import PNode, warn_about_upcoming_attributes_field_on_nodes
 from _pytask.node_protocols import PPathNode
 from _pytask.node_protocols import PProvisionalNode
 from _pytask.node_protocols import PTask
@@ -387,14 +387,7 @@ def pytask_collect_node(  # noqa: C901, PLR0912
     node = node_info.value
 
     if isinstance(node, (PNode, PProvisionalNode)) and not hasattr(node, "attributes"):
-        warnings.warn(
-            "PNode and PProvisionalNode will require an 'attributes' field starting "
-            "with pytask v0.6.0. It is a dictionary with any type of key and values "
-            "similar to PTask. See https://tinyurl.com/pytask-custom-nodes for more "
-            "information about adjusting your custom nodes.",
-            stacklevel=1,
-            category=FutureWarning,
-        )
+        warn_about_upcoming_attributes_field_on_nodes()
 
     if isinstance(node, DirectoryNode):
         if node.root_dir is None:

src/_pytask/console.py

@@ -12,6 +12,7 @@
 from typing import Any
 from typing import Callable
 from typing import Literal
+import warnings
 
 from rich.console import Console
 from rich.console import RenderableType
@@ -25,7 +26,7 @@
 from rich.tree import Tree
 
 from _pytask.data_catalog_utils import DATA_CATALOG_NAME_FIELD
-from _pytask.node_protocols import PNode
+from _pytask.node_protocols import PNode, warn_about_upcoming_attributes_field_on_nodes
 from _pytask.node_protocols import PPathNode
 from _pytask.node_protocols import PProvisionalNode
 from _pytask.node_protocols import PTaskWithPath
@@ -148,8 +149,9 @@ def format_node_name(
     """Format the name of a node."""
     if isinstance(node, PPathNode):
         if node.name != node.path.as_posix():
-            if data_catalog_name := node.attributes.get(DATA_CATALOG_NAME_FIELD):
+            if data_catalog_name := getattr(node, "attributes", {}).get(DATA_CATALOG_NAME_FIELD):
                 return Text(f"{data_catalog_name}::{node.name}")
+            warn_about_upcoming_attributes_field_on_nodes()
             return Text(node.name)
         name = shorten_path(node.path, paths)
         return Text(name)

src/_pytask/data_catalog.py

@@ -20,7 +20,7 @@
 from _pytask.data_catalog_utils import DATA_CATALOG_NAME_FIELD
 from _pytask.exceptions import NodeNotCollectedError
 from _pytask.models import NodeInfo
-from _pytask.node_protocols import PNode
+from _pytask.node_protocols import PNode, warn_about_upcoming_attributes_field_on_nodes
 from _pytask.node_protocols import PPathNode
 from _pytask.node_protocols import PProvisionalNode
 from _pytask.nodes import PickleNode
@@ -139,4 +139,9 @@ def add(self, name: str, node: PNode | PProvisionalNode | Any = None) -> None:
                 msg = f"{node!r} cannot be parsed."
                 raise NodeNotCollectedError(msg)
             self._entries[name] = collected_node
-        self._entries[name].attributes[DATA_CATALOG_NAME_FIELD] = self.name
+
+        node = self._entries[name]
+        if hasattr(node, "attributes"):
+            node.attributes[DATA_CATALOG_NAME_FIELD] = self.name
+        else:
+            warn_about_upcoming_attributes_field_on_nodes()

src/_pytask/node_protocols.py

@@ -5,6 +5,7 @@
 from typing import Callable
 from typing import Protocol
 from typing import runtime_checkable
+import warnings
 
 if TYPE_CHECKING:
     from pathlib import Path
@@ -138,3 +139,14 @@ def load(self, is_product: bool = False) -> Any:  # pragma: no cover
 
     def collect(self) -> list[Any]:
         """Collect the objects that are defined by the provisional nodes."""
+
+
+def warn_about_upcoming_attributes_field_on_nodes() -> None:
+    warnings.warn(
+        "PNode and PProvisionalNode will require an 'attributes' field starting "
+        "with pytask v0.6.0. It is a dictionary with any type of key and values "
+        "similar to PTask. See https://tinyurl.com/pytask-custom-nodes for more "
+        "information about adjusting your custom nodes.",
+        stacklevel=1,
+        category=FutureWarning,
+    )