Add test.

Author: tobiasraabe

src/pytask_stata/collect.py

@@ -3,6 +3,7 @@
 
 import subprocess
 import warnings
+from pathlib import Path
 from typing import Any
 
 from pytask import has_mark
@@ -21,8 +22,6 @@
 from pytask import TaskWithoutPath
 from pytask_stata.shared import convert_task_id_to_name_of_log_file
 from pytask_stata.shared import stata
-from pathlib import Path
-
 
 
 def run_stata_script(

src/pytask_stata/execute.py

@@ -1,12 +1,13 @@
 """Execute tasks."""
 from __future__ import annotations
+from pathlib import Path
 
 import re
 
 from pytask import has_mark
 from pytask import hookimpl
 from pytask import PTask
-from pytask import Session
+from pytask import Session, PTaskWithPath
 from pytask_stata.shared import convert_task_id_to_name_of_log_file
 from pytask_stata.shared import STATA_COMMANDS
 
@@ -37,7 +38,10 @@ def pytask_execute_task_teardown(session: Session, task: PTask) -> None:
     if has_mark(task, "stata"):
         if session.config["platform"] == "win32":
             log_name = convert_task_id_to_name_of_log_file(task)
-            path_to_log = task.path.with_name(log_name).with_suffix(".log")
+            if isinstance(task, PTaskWithPath):
+                path_to_log = task.path.with_name(log_name).with_suffix(".log")
+            else:
+                path_to_log = Path.cwd(log_name).with_name(log_name).with_suffix(".log")
         else:
             node = task.depends_on["_script"]
             path_to_log = node.path.with_suffix(".log")

src/pytask_stata/shared.py

@@ -8,7 +8,6 @@
 from typing import TYPE_CHECKING
 
 
-
 if TYPE_CHECKING:
     from pytask import PTask
     from pathlib import Path
@@ -83,7 +82,12 @@ def convert_task_id_to_name_of_log_file(task: PTask) -> str:
     """
     id_ = getattr(task, "short_name", task.name)
     id_without_parent_directories = id_.rsplit("/")[-1]
-    converted_id = id_without_parent_directories.replace(".", "_").replace("::", "_")
+    converted_id = (
+        id_without_parent_directories.replace(".", "_")
+        .replace("::", "_")
+        .replace("<", "")
+        .replace(">", "")
+    )
     return converted_id
 
 

tests/conftest.py

@@ -1,13 +1,13 @@
 from __future__ import annotations
 
 import shutil
+import sys
+from contextlib import contextmanager
 from typing import Callable
 
 import pytest
 from click.testing import CliRunner
 from pytask_stata.config import STATA_COMMANDS
-import sys
-from contextlib import contextmanager
 
 
 needs_stata = pytest.mark.skipif(

tests/test_execute.py

@@ -6,9 +6,9 @@
 from pathlib import Path
 
 import pytest
+from pytask import build
 from pytask import cli
 from pytask import ExitCode
-from pytask import build
 from pytask import Mark
 from pytask import Session
 from pytask import Task
@@ -196,3 +196,33 @@ def task_run_do_file():
 
     assert result.exit_code == ExitCode.COLLECTION_FAILED
     assert "has multiple @pytask.mark.stata marks" in result.output
+
+
+@needs_stata
+@pytest.mark.end_to_end()
+def test_with_task_without_path(runner, tmp_path):
+    task_source = """
+    import pytask
+    from pytask import task
+
+    task_example = pytask.mark.stata(script="script.do")(
+        pytask.mark.produces("auto.dta")(task()(lambda x: None))
+    )
+    """
+    tmp_path.joinpath("task_example.py").write_text(textwrap.dedent(task_source))
+
+    do_file = """
+    sysuse auto, clear
+    save auto
+    """
+    tmp_path.joinpath("script.do").write_text(textwrap.dedent(do_file))
+
+    result = runner.invoke(cli, [tmp_path.as_posix(), "--stata-keep-log"])
+
+    assert result.exit_code == ExitCode.OK
+    assert tmp_path.joinpath("auto.dta").exists()
+
+    if sys.platform == "win32":
+        assert tmp_path.joinpath("lambda.log").exists()
+    else:
+        assert tmp_path.joinpath("lambda.log").exists()