Release v0.0.4 and fix pytask_collect_task_teardown. (#4)

Author: tobiasraabe

CHANGES.rst

@@ -6,6 +6,12 @@ chronological order. Releases follow `semantic versioning <https://semver.org/>`
 all releases are available on `Anaconda.org <https://anaconda.org/pytask/pytask-r>`_.
 
 
+0.0.4 - 2020-10-14
+------------------
+
+- :gh:`4` fixes ``pytask_collect_task_teardown`` with non-R tasks and releases 0.0.4.
+
+
 0.0.3 - 2020-10-04
 ------------------
 

setup.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 0.0.3
+current_version = 0.0.4
 parse = (?P<major>\d+)\.(?P<minor>\d+)(\.(?P<patch>\d+))(\-?((dev)?(?P<dev>\d+))?)
 serialize = 
 	{major}.{minor}.{patch}dev{dev}

setup.py

@@ -3,7 +3,7 @@
 
 setup(
     name="pytask-r",
-    version="0.0.3",
+    version="0.0.4",
     packages=find_packages(where="src"),
     package_dir={"": "src"},
     entry_points={"pytask": ["pytask_r = pytask_r.plugin"]},

src/pytask_r/__init__.py

@@ -1 +1 @@
-__version__ = "0.0.3"
+__version__ = "0.0.4"

src/pytask_r/collect.py

@@ -64,7 +64,12 @@ def pytask_collect_task(session, path, name, obj):
 
 @hookimpl
 def pytask_collect_task_teardown(task):
-    if task is not None:
+    """Perform some checks.
+
+    Remove is task is none check with pytask 0.0.9.
+
+    """
+    if task is not None and get_specific_markers_from_task(task, "r"):
         if isinstance(task.depends_on[0], FilePathNode) and task.depends_on[
             0
         ].value.suffix not in [".r", ".R"]:

tests/test_execute.py

@@ -1,3 +1,4 @@
+import itertools
 import os
 import textwrap
 from contextlib import ExitStack as does_not_raise  # noqa: N813
@@ -13,6 +14,36 @@ class DummyTask:
     pass
 
 
+@pytest.mark.end_to_end
+@pytest.mark.parametrize(
+    "dependencies, products",
+    itertools.product(
+        ([], ["in.txt"], ["in_1.txt", "in_2.txt"]),
+        (["out.txt"], ["out_1.txt", "out_2.txt"]),
+    ),
+)
+def test_normal_flow_w_varying_dependencies_products(tmp_path, dependencies, products):
+    source = f"""
+    import pytask
+    from pathlib import Path
+
+
+    @pytask.mark.depends_on({dependencies})
+    @pytask.mark.produces({products})
+    def task_dummy(depends_on, produces):
+        if not isinstance(produces, list):
+            produces = [produces]
+        for product in produces:
+            product.touch()
+    """
+    tmp_path.joinpath("task_dummy.py").write_text(textwrap.dedent(source))
+    for dependency in dependencies:
+        tmp_path.joinpath(dependency).touch()
+
+    session = main({"paths": tmp_path})
+    assert session.exit_code == 0
+
+
 @pytest.mark.unit
 @pytest.mark.parametrize(
     "found_r, expectation",