Remove unnecessary hook implementation. (#8)

Author: tobiasraabe

.github/workflows/main.yml

@@ -1,4 +1,4 @@
-name: Continuous Integration Workflow
+name: main
 
 # Automatically cancel a previous run.
 concurrency:

CHANGES.rst

@@ -8,7 +8,13 @@ them in reverse chronological order. Releases follow `semantic versioning
 <https://anaconda.org/conda-forge/pytask-julia>`_.
 
 
-0.1.0 - 2022-xx-xx
+0.2.0 - 2022-xx-xx
+------------------
+
+- :gh:`8` removes an unnecessary hook.
+
+
+0.1.0 - 2022-01-19
 ------------------
 
 - :gh:`2` polishes the first release of pytask-julia. (Thanks to :ghuser:`hmgaudecker`,

README.rst

@@ -19,7 +19,7 @@ pytask-julia
     :alt: PyPI - License
     :target: https://pypi.org/project/pytask-julia
 
-.. image:: https://img.shields.io/github/workflow/status/pytask-dev/pytask-julia/Continuous%20Integration%20Workflow/main
+.. image:: https://img.shields.io/github/workflow/status/pytask-dev/pytask-julia/main/main
    :target: https://github.com/pytask-dev/pytask-julia/actions?query=branch%3Amain
 
 .. image:: https://codecov.io/gh/pytask-dev/pytask-julia/branch/main/graph/badge.svg

src/pytask_julia/collect.py

@@ -9,9 +9,7 @@
 
 from _pytask.config import hookimpl
 from _pytask.mark_utils import get_specific_markers_from_task
-from _pytask.mark_utils import has_marker
 from _pytask.nodes import FilePathNode
-from _pytask.nodes import PythonFunctionTask
 from _pytask.parametrize import _copy_func
 
 
@@ -40,23 +38,6 @@ def run_jl_script(julia):
     subprocess.run(julia, check=True)
 
 
-@hookimpl
-def pytask_collect_task(session, path, name, obj):
-    """Collect a task which is a function.
-
-    There is some discussion on how to detect functions in this `thread
-    <https://stackoverflow.com/q/624926/7523785>`_. :class:`types.FunctionType` does not
-    detect built-ins which is not possible anyway.
-
-    """
-    if name.startswith("task_") and callable(obj) and has_marker(obj, "julia"):
-        task = PythonFunctionTask.from_path_name_function_session(
-            path, name, obj, session
-        )
-
-        return task
-
-
 @hookimpl
 def pytask_collect_task_teardown(session, task):
     """Perform some checks."""

tests/test_collect.py

@@ -8,7 +8,6 @@
 from pytask_julia.collect import _merge_all_markers
 from pytask_julia.collect import _prepare_cmd_options
 from pytask_julia.collect import julia
-from pytask_julia.collect import pytask_collect_task
 from pytask_julia.collect import pytask_collect_task_teardown
 
 
@@ -55,24 +54,6 @@ def test_merge_all_markers(marks, expected):
     assert out == expected
 
 
-@pytest.mark.unit
-@pytest.mark.parametrize(
-    "name, expected",
-    [("task_dummy", True), ("invalid_name", None)],
-)
-def test_pytask_collect_task(name, expected):
-    session = DummyClass()
-    path = Path("some_path")
-    task_dummy.pytaskmark = [Mark("julia", (), {})]
-
-    task = pytask_collect_task(session, path, name, task_dummy)
-
-    if expected:
-        assert task
-    else:
-        assert not task
-
-
 @pytest.mark.unit
 @pytest.mark.parametrize(
     "depends_on, produces, expectation",