-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Labels
enhancementNew feature or requestNew feature or request
Description
If the spreading is smaller than 1 currently the reappearing_cross_section calculation returns an empty array:
pyroll-core/pyroll/core/roll_pass/hookimpls/roll_pass.py
Lines 190 to 192 in 93bfbaf
| @RollPass.reappearing_cross_section | |
| def reappearing_cross_section(self: RollPass): | |
| return difference(self.out_profile.cross_section, self.in_profile.cross_section) |
Though spreading smaller than 1 is a circumstance that can realistically happen (at high rolling velocities for example) so the area difference should still be included somewhere by either:
- including it in the current reappearing_cross_section - though this would be semantically incorrect, as its not actually a reappearing cross section then
- add an additional value like "reduced_cross_section" (name is still misleading but i cant think of a better one) that only returns an array if the circumstance desribed above is the case.
I would say the first is still the better option, just so that bloat is reduced (and it also dirctly works with existing code).
@axtimhaus / @ChRen95 What do you think?
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request