Skip to content

Commit dd828bd

Browse files
scripts/sysinstall.py:Avoid errors from upgrading system pip.
`sudo pip --upgrade pip` can fail to install apt's pip.
1 parent b117956 commit dd828bd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

scripts/sysinstall.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ def run(command, env_extra=None):
227227
#
228228
if pip == 'sudo':
229229
log('## Installing Python packages required for building MuPDF and PyMuPDF.')
230-
run(f'sudo pip install --upgrade pip')
230+
#run(f'sudo pip install --upgrade pip') # Breaks on Github see: https://github.com/pypa/get-pip/issues/226.
231231
names = test_py.wrap_get_requires_for_build_wheel(f'{__file__}/../..')
232232
run(f'sudo pip install {names}')
233233

@@ -275,7 +275,7 @@ def run(command):
275275
run(f'. {venv_name}/bin/activate && pip install --upgrade installer')
276276
run(f'{env} {venv_name}/bin/python -m pip wheel -vv -w dist {os.path.abspath(pymupdf_dir)}')
277277
elif pip == 'sudo':
278-
run(f'sudo pip install --upgrade pip')
278+
#run(f'sudo pip install --upgrade pip') # Breaks on Github see: https://github.com/pypa/get-pip/issues/226.
279279
run(f'sudo pip install installer')
280280
run(f'{env} pip wheel -vv -w dist {os.path.abspath(pymupdf_dir)}')
281281
else:

0 commit comments

Comments
 (0)