fix: scope wrong-import-position pragma to specific line only

Signed-off-by: Emmanuel Ferdman <[email protected]>

Author: emmanuel-ferdman

pylint/checkers/imports.py

@@ -703,7 +703,7 @@ def _check_position(self, node: ImportNode) -> None:
         # it means the import comes after it and therefore is not well placed
         if self._first_non_import_node:
             if self.linter.is_message_enabled(
-                "wrong-import-position", self._first_non_import_node.fromlineno
+                "wrong-import-position", node.fromlineno
             ):
                 self.add_message(
                     "wrong-import-position", node=node, args=node.as_string()

tests/functional/d/disable_wrong_import_position.py

@@ -1,7 +1,10 @@
-"""Checks that disabling 'wrong-import-position' on a statement prevents it from
-invalidating subsequent imports."""
+"""Checks that disabling 'wrong-import-position' only affects the specific line.
+
+A pragma on a non-import statement should not affect subsequent import statements.
+This demonstrates the correct behavior after fixing the bug.
+"""
 # pylint: disable=unused-import
 
 CONSTANT = True  # pylint: disable=wrong-import-position
 
-import sys
+import sys  # [wrong-import-position]

tests/functional/d/disable_wrong_import_position.txt

@@ -0,0 +1 @@
+wrong-import-position:10:0:10:10::"Import ""import sys"" should be placed at the top of the module":UNDEFINED

tests/functional/w/wrong_import_position_pragma_scope.py

@@ -0,0 +1,23 @@
+"""Test that wrong-import-position pragma suppression is correctly scoped."""
+# pylint: disable=unused-import,invalid-name
+
+import logging
+import sys
+
+# This pragma should not affect subsequent import statements
+logger = logging.getLogger()  # pylint: disable=wrong-import-position
+logging.basicConfig(level='DEBUG')
+
+logger.debug('importing modules...')
+import os  # [wrong-import-position]
+import pathlib  # [wrong-import-position]
+import random  # [wrong-import-position]
+logger.debug('done importing')
+
+# Test that pragma on import line works correctly (this import should not be flagged)
+constant_var = "test"
+import json  # pylint: disable=wrong-import-position
+
+# Test that subsequent imports are not affected by the pragma above
+import csv  # [wrong-import-position]
+import re  # [wrong-import-position]

tests/functional/w/wrong_import_position_pragma_scope.txt

@@ -0,0 +1,5 @@
+wrong-import-position:19:0:19:9::"Import ""import os"" should be placed at the top of the module":UNDEFINED
+wrong-import-position:20:0:20:14::"Import ""import pathlib"" should be placed at the top of the module":UNDEFINED
+wrong-import-position:21:0:21:13::"Import ""import random"" should be placed at the top of the module":UNDEFINED
+wrong-import-position:29:0:29:10::"Import ""import csv"" should be placed at the top of the module":UNDEFINED
+wrong-import-position:30:0:30:9::"Import ""import re"" should be placed at the top of the module":UNDEFINED