Merge pull request #2950 from zoldalma999/window-subclass

Make window subclassable

Author: damusss

buildconfig/stubs/pygame/window.pyi

@@ -6,7 +6,7 @@ from pygame.rect import Rect
 from pygame.surface import Surface
 
 def get_grabbed_window() -> Optional[Window]: ...
-@final
+
 class Window:
     def __init__(
         self,

docs/reST/ref/window.rst

@@ -46,6 +46,7 @@
 
    .. versionadded:: 2.4.0
    .. versionchanged:: 2.5.0 when ``opengl`` is ``True``, the ``Window`` has an OpenGL context created by pygame
+   .. versionchanged:: 2.5.1 Window is now a base class, allowing subclassing
 
 
    .. attribute:: grab_mouse

src_c/window.c

@@ -1141,6 +1141,7 @@ static PyTypeObject pgWindow_Type = {
     PyVarObject_HEAD_INIT(NULL, 0).tp_name = "pygame.window.Window",
     .tp_basicsize = sizeof(pgWindowObject),
     .tp_dealloc = (destructor)window_dealloc,
+    .tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE,
     .tp_doc = DOC_WINDOW,
     .tp_methods = window_methods,
     .tp_init = (initproc)window_init,

test/window_test.py

@@ -397,6 +397,24 @@ def test_window_opengl(self):
         pygame.display.quit()
         pygame.init()
 
+    def test_window_subclassable(self):
+        class WindowSubclass(Window):
+            def __init__(self, title="Different title", size=(640, 480), **flags):
+                super().__init__(title, size, pygame.WINDOWPOS_CENTERED, **flags)
+                self.attribute = 10
+
+        window = WindowSubclass()
+        self.assertTrue(issubclass(WindowSubclass, Window))
+        self.assertIsInstance(window, WindowSubclass)
+        self.assertEqual(window.title, "Different title")
+        self.assertEqual(window.attribute, 10)
+        window.destroy()
+
+        pygame.display.set_mode((200, 200))
+        window = WindowSubclass.from_display_module()
+        self.assertIsInstance(window, WindowSubclass)
+        self.assertEqual(window.size, (200, 200))
+
     def tearDown(self):
         self.win.destroy()