chore: Optimize iterator advance() call (#4237)

Skylion007 · web-flow · commit 8781daf6e6c2 · 2022-10-12T16:46:40.000-04:00
diff --git a/include/pybind11/pytypes.h b/include/pybind11/pytypes.h
@@ -1382,7 +1382,7 @@ class iterator : public object {
 private:
     void advance() {
         value = reinterpret_steal<object>(PyIter_Next(m_ptr));
-        if (PyErr_Occurred()) {
+        if (value.ptr() == nullptr && PyErr_Occurred()) {
             throw error_already_set();
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -1382,7 +1382,7 @@ class iterator : public object {`
`1382`	`1382`	`private:`
`1383`	`1383`	`void advance() {`
`1384`	`1384`	`value = reinterpret_steal<object>(PyIter_Next(m_ptr));`
`1385`		`- if (PyErr_Occurred()) {`
	`1385`	`+ if (value.ptr() == nullptr && PyErr_Occurred()) {`
`1386`	`1386`	`throw error_already_set();`
`1387`	`1387`	`}`
`1388`	`1388`	`}`