Skip to content

Commit 7d3b13d

Browse files
authored
Fix: remove sigstore step from publish build as it's duplicate (#287)
* Fix: remove sigstore step from publish build as it's duplicate * Update .github/workflows/publish-pypi.yml
1 parent 0a98778 commit 7d3b13d

File tree

2 files changed

+18
-47
lines changed

2 files changed

+18
-47
lines changed

.github/workflows/publish-pypi.yml

Lines changed: 2 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -64,47 +64,12 @@ jobs:
6464
permissions:
6565
id-token: write # this permission is mandatory for pypi publishing
6666
steps:
67-
# Version 4 doesn't support github enterprise yet
6867
- name: Download all the dists
6968
uses: actions/download-artifact@v4
7069
with:
7170
name: python-package-distributions
7271
path: dist/
7372
- name: Publish package to PyPI
74-
# Only publish to real PyPI on release
73+
# Only publish to PyPI on release
7574
if: github.event_name == 'release'
76-
uses: pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc # v1.12.4
77-
sign-files:
78-
name: >-
79-
Sign the Python 🐍 distribution 📦 with Sigstore
80-
and upload them to GitHub Release
81-
# Only sign on release
82-
if: github.repository_owner == 'pyopensci' && github.event_name == 'release'
83-
needs:
84-
- publish
85-
runs-on: ubuntu-latest
86-
permissions:
87-
contents: write # this permission is mandatory for modifying GitHub Releases
88-
id-token: write # this permission is mandatory for sigstore
89-
steps:
90-
- name: Download all the dists
91-
uses: actions/download-artifact@v4
92-
with:
93-
name: python-package-distributions
94-
path: dist/
95-
- name: Sign the dists with Sigstore
96-
uses: sigstore/gh-action-sigstore-python@f514d46b907ebcd5bedc05145c03b69c1edd8b46 # v3.0.0
97-
with:
98-
inputs: >-
99-
./dist/*.tar.gz
100-
./dist/*.whl
101-
- name: Upload artifact signatures to GitHub Release
102-
env:
103-
GITHUB_TOKEN: ${{ github.token }}
104-
# Upload to GitHub Release using the `gh` CLI.
105-
# `dist/` contains the built packages, and the
106-
# sigstore-produced signatures and certificates.
107-
run: >-
108-
gh release upload
109-
"$GITHUB_REF_NAME" dist/**
110-
--repo '${{ github.repository }}'
75+
uses: pypa/gh-action-pypi-publish@76f52bc884231f62b9a034ebfe128415bbaabdfc # v1.12.4

CHANGELOG.md

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,21 @@ See [GitHub releases](https://github.com/pyOpenSci/pyosMeta/releases) page for a
66

77
## [Unreleased]
88

9+
* Fix: remove sigstore from pypi publish workflow (@lwasser, #286)
10+
911
## [v1.7] - 2025-05-19
1012

1113
### Added
14+
1215
* Added `tqdm` as a dependency to improve progress monitoring when running data processing scripts (@banesullivan)
1316
* Test missing community partnerships section (@banesullivan, #268)
1417
* enh: use graphql to consolidate api calls by (@lwasser, #267)
15-
* Consistent logging by @banesullivan in https://github.com/pyOpenSci/pyosMeta/pull/270
18+
* Consistent logging by @banesullivan in <https://github.com/pyOpenSci/pyosMeta/pull/270>
1619
* enh(ci): Add zizmor to `pre-commit-config.yaml` (@klmcadams, #283)
1720
* enh(docs): Docstrings to docs (@mrgah, #281)
1821

1922
### Fixed
23+
2024
* Use a consistent logger for informational/debug outputs. Using print statements can make it tough to track down which line of code emitted the message and using the `warnings` module will suppress recurring warnings (@banesullivan)
2125
* Fix: update deprecated sigstore action by (@lwasser, #265)
2226
* Remove duplicate "Add help-wanted issues to help wanted board" job by (@banesullivan, #269)
@@ -25,23 +29,25 @@ See [GitHub releases](https://github.com/pyOpenSci/pyosMeta/releases) page for a
2529
* enh(docs): update pyosmeta release workflow docs (@lwasser, #278)
2630

2731
## Thank you!! New Contributors to this release ✨
32+
2833
@klmcadams, @mrgah
2934

3035
## [v1.6] - 2025-02-17
3136

3237
## What's Changed
3338

34-
* [hotfix] handle packages that lack a description on GitHub by @banesullivan in https://github.com/pyOpenSci/pyosMeta/pull/257
35-
* In CONTRIBUTING.md, add more specifics on configuring API token #194 by @hariprakash619 in https://github.com/pyOpenSci/pyosMeta/pull/255
36-
* docs: add hariprakash619 as a contributor for doc by @allcontributors in https://github.com/pyOpenSci/pyosMeta/pull/256
37-
* Reorder badges and add more CI badges in README by @willingc in https://github.com/pyOpenSci/pyosMeta/pull/258
38-
* Update CHANGELOG.md for 1.6 by @willingc in https://github.com/pyOpenSci/pyosMeta/pull/260
39-
* Update contributor and review data by @github-actions in https://github.com/pyOpenSci/pyosMeta/pull/251
40-
* Update contributor and review data by @github-actions in https://github.com/pyOpenSci/pyosMeta/pull/253
41-
* Update contributor and review data by @github-actions in https://github.com/pyOpenSci/pyosMeta/pull/262
39+
* [hotfix] handle packages that lack a description on GitHub by @banesullivan in <https://github.com/pyOpenSci/pyosMeta/pull/257>
40+
* In CONTRIBUTING.md, add more specifics on configuring API token #194 by @hariprakash619 in <https://github.com/pyOpenSci/pyosMeta/pull/255>
41+
* docs: add hariprakash619 as a contributor for doc by @allcontributors in <https://github.com/pyOpenSci/pyosMeta/pull/256>
42+
* Reorder badges and add more CI badges in README by @willingc in <https://github.com/pyOpenSci/pyosMeta/pull/258>
43+
* Update CHANGELOG.md for 1.6 by @willingc in <https://github.com/pyOpenSci/pyosMeta/pull/260>
44+
* Update contributor and review data by @github-actions in <https://github.com/pyOpenSci/pyosMeta/pull/251>
45+
* Update contributor and review data by @github-actions in <https://github.com/pyOpenSci/pyosMeta/pull/253>
46+
* Update contributor and review data by @github-actions in <https://github.com/pyOpenSci/pyosMeta/pull/262>
4247

4348
## New Contributors
44-
* @hariprakash619 made their first contribution in https://github.com/pyOpenSci/pyosMeta/pull/255
49+
50+
* @hariprakash619 made their first contribution in <https://github.com/pyOpenSci/pyosMeta/pull/255>
4551

4652
## [v1.5] - 2025-01-14
4753

0 commit comments

Comments
 (0)