Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ad ID Permission Declaration in PWABuilder Packager Tool #4822

Open
ekkaiasmith opened this issue Oct 1, 2024 · 3 comments
Open

Add Ad ID Permission Declaration in PWABuilder Packager Tool #4822

ekkaiasmith opened this issue Oct 1, 2024 · 3 comments

Comments

@ekkaiasmith
Copy link

ekkaiasmith commented Oct 1, 2024

Tell us about your feature idea

It would be beneficial to add a feature in the PWABuilder packager tool that allows developers to declare the Ad ID permission (com.google.android.gms.permission.AD_ID) directly. This feature should automatically insert the following permission into the AndroidManifest.xml when building the Android package for a PWA:

<uses-permission android:name="com.google.android.gms.permission.AD_ID" />

Do you have an implementation or a solution in mind?

Add an option in the PWABuilder interface where developers can specify whether their app requires Ad ID permission. If enabled, the packager will automatically add the following permission to the generated AndroidManifest.xml file:

<uses-permission android:name="com.google.android.gms.permission.AD_ID" />

Have you considered any alternatives?

Currently I don't see any other alternatives than to decompile the .aab and editing the manifest myself.

Tasks

Preview Give feedback
No tasks being tracked yet.
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@ziadwagdy
Copy link

I faced the same issue and resolved it by enabling the "Include Source Code" option while packaging for Android.
image

After that, I was able to edit the AndroidManifest.xml file directly and add the required permissions.
image

Then, using Android Studio, I navigated to Build -> Generate Signed App Bundle or APK and generated my signed .aab file, which worked perfectly.

This method offers an alternative solution.

@victorsferreira
Copy link

shouldn't we just mark this option as "NO" when submitting the app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants