From 603c4e7ef23b6b31d6b057b49c7bb5a0d2d8d128 Mon Sep 17 00:00:00 2001 From: Areeba Turabi Date: Tue, 22 Aug 2023 11:12:20 -0700 Subject: [PATCH 1/3] Update snow events definition for Townsend model --- pvlib/snow.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pvlib/snow.py b/pvlib/snow.py index 8cd1309bb6..17d7f53a72 100644 --- a/pvlib/snow.py +++ b/pvlib/snow.py @@ -230,8 +230,10 @@ def loss_townsend(snow_total, snow_events, surface_tilt, relative_humidity, Snow received each month. Referred to as S in [1]_. [cm] snow_events : array-like - Number of snowfall events each month. May be int or float type for - the average events in a typical month. Referred to as N in [1]_. + Number of snowfall events each month. Snow events are defined as days + in the month that have snowfall greater than 1 inch. May be int or + float type for the average events in a typical month. Referred to as N + in [1]_. surface_tilt : float Tilt angle of the array. [deg] From bbc44140cac54a13cbb039a64011fbb5888fda1d Mon Sep 17 00:00:00 2001 From: Areeba Turabi Date: Tue, 22 Aug 2023 11:25:54 -0700 Subject: [PATCH 2/3] Update whatsnew --- docs/sphinx/source/whatsnew/v0.10.2.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/sphinx/source/whatsnew/v0.10.2.rst b/docs/sphinx/source/whatsnew/v0.10.2.rst index c196a879e3..d462d08a8a 100644 --- a/docs/sphinx/source/whatsnew/v0.10.2.rst +++ b/docs/sphinx/source/whatsnew/v0.10.2.rst @@ -37,6 +37,8 @@ Documentation (:issue:`1722`, :pull:`1723`) * Fix and update example in :py:func:`pvlib.pvsystem.retrieve_sam`. (:issue:`1741`, :pull:`1833`) +* Update definition of snow events parameter for :py:func:`pvlib.snow.loss_townsend`. + (:issue:`1839`, :pull:`1839`) Requirements ~~~~~~~~~~~~ @@ -48,3 +50,4 @@ Contributors * Abigail Jones (:ghuser:`ajonesr`) * Taos Transue (:ghuser:`reepoi`) * NativeSci (:ghuser:`nativesci`) +* Areeba Turabi (:ghuser:`aturabi`) \ No newline at end of file From aaee0dea3d6f1f277da9c3bda89ade6dfaa2e64d Mon Sep 17 00:00:00 2001 From: Areeba Turabi Date: Tue, 22 Aug 2023 16:13:58 -0700 Subject: [PATCH 3/3] Add note on origin of new definition --- pvlib/snow.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pvlib/snow.py b/pvlib/snow.py index 17d7f53a72..b245c21945 100644 --- a/pvlib/snow.py +++ b/pvlib/snow.py @@ -276,7 +276,9 @@ def loss_townsend(snow_total, snow_events, surface_tilt, relative_humidity, axis to the module edge. The parameter `string_factor` is an enhancement added to the model after - publication of [1]_ per private communication with the model's author. + publication of [1]_ per private communication with the model's author. The + definition for snow events documented above is also based on private + communication with the model's author. References ----------