Skip to content

Commit d084baa

Browse files
aturabicpr-aturabi
andauthored
Update snow events parameter docs for Townsend snow loss model (#1840)
* Update snow events definition for Townsend model * Update whatsnew * Add note on origin of new definition --------- Co-authored-by: Areeba Turabi <[email protected]>
1 parent 3e16ba9 commit d084baa

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

docs/sphinx/source/whatsnew/v0.10.2.rst

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ Documentation
3939
(:issue:`1741`, :pull:`1833`)
4040
* Fix error in :py:func:`pvlib.iotools.get_pvgis_hourly` documentation of `surface_azimuth`.
4141
(:issue:`1724`, :pull:`1838`)
42-
42+
* Update definition of snow events parameter for :py:func:`pvlib.snow.loss_townsend`.
43+
(:issue:`1839`, :pull:`1840`)
44+
4345
Requirements
4446
~~~~~~~~~~~~
4547

@@ -51,3 +53,4 @@ Contributors
5153
* Taos Transue (:ghuser:`reepoi`)
5254
* NativeSci (:ghuser:`nativesci`)
5355
* Lukas Grossar (:ghuser:`tongpu`)
56+
* Areeba Turabi (:ghuser:`aturabi`)

pvlib/snow.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,10 @@ def loss_townsend(snow_total, snow_events, surface_tilt, relative_humidity,
230230
Snow received each month. Referred to as S in [1]_. [cm]
231231
232232
snow_events : array-like
233-
Number of snowfall events each month. May be int or float type for
234-
the average events in a typical month. Referred to as N in [1]_.
233+
Number of snowfall events each month. Snow events are defined as days
234+
in the month that have snowfall greater than 1 inch. May be int or
235+
float type for the average events in a typical month. Referred to as N
236+
in [1]_.
235237
236238
surface_tilt : float
237239
Tilt angle of the array. [deg]
@@ -274,7 +276,9 @@ def loss_townsend(snow_total, snow_events, surface_tilt, relative_humidity,
274276
axis to the module edge.
275277
276278
The parameter `string_factor` is an enhancement added to the model after
277-
publication of [1]_ per private communication with the model's author.
279+
publication of [1]_ per private communication with the model's author. The
280+
definition for snow events documented above is also based on private
281+
communication with the model's author.
278282
279283
References
280284
----------

0 commit comments

Comments
 (0)