Skip to content

Commit 0a00f1b

Browse files
committed
Changes from code review
1 parent c24e013 commit 0a00f1b

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

docs/sphinx/source/reference/effects_on_pv_system_output/spectrum.rst

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,10 @@ Spectrum
1212
spectrum.calc_spectral_mismatch_field
1313
spectrum.spectral_factor_caballero
1414
spectrum.spectral_factor_firstsolar
15-
spectrum.spectral_factor_sapm
16-
spectrum.spectral_factor_pvspec
1715
spectrum.spectral_factor_jrc
16+
spectrum.spectral_factor_polo
17+
spectrum.spectral_factor_pvspec
18+
spectrum.spectral_factor_sapm
1819
spectrum.sr_to_qe
1920
spectrum.qe_to_sr
2021
spectrum.average_photon_energy

pvlib/spectrum/mismatch.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -723,22 +723,24 @@ def spectral_factor_polo(precipitable_water, airmass_absolute, aod500, aoi,
723723
precipitable_water : numeric
724724
atmospheric precipitable water. [cm]
725725
airmass_absolute : numeric
726-
Absolute airmass. [unitless]
726+
absolute (pressure-adjusted) airmass. See :term:`airmass_absolute`.
727+
[unitless]
727728
aod500 : numeric
728729
atmospheric aerosol optical depth at 500 nm. [unitless]
729730
aoi : numeric
730-
Angle of incidence on the vertical surface. [degrees]
731+
Angle of incidence on the vertical surface. See :term:`aoi`.
732+
[degrees]
731733
altitude: numeric
732734
altitude over sea level. [m]
733735
module_type : str, optional
734736
One of the following PV technology strings from [1]_:
735737
736738
* ``'cdte'`` - anonymous CdTe module.
737-
* ``'monosi'`` - anonymous monocrystalline Si module.
739+
* ``'monosi'`` - anonymous monocrystalline silicon module.
738740
* ``'cigs'`` - anonymous copper indium gallium selenide module.
739741
* ``'asi'`` - anonymous amorphous silicon module.
740-
albedo
741-
Ground albedo (default value 0.2). [unitless]
742+
albedo : float, optional
743+
Ground albedo (default value 0.2). See :term:`albedo`. [unitless]
742744
743745
coefficients : array-like, optional
744746
user-defined coefficients, if not using one of the coefficient
@@ -754,9 +756,9 @@ def spectral_factor_polo(precipitable_water, airmass_absolute, aod500, aoi,
754756
755757
References
756758
----------
757-
[1] J. Polo and C. Sanz-Saiz, 'Development of spectral mismatch models
758-
for BIPV applications in building façades', Renewable Energy, vol. 245,
759-
p. 122820, Jun. 2025,:doi:`10.1016/j.renene.2025.122820`
759+
.. [1] J. Polo and C. Sanz-Saiz, 'Development of spectral mismatch models
760+
for BIPV applications in building façades', Renewable Energy, vol. 245,
761+
p. 122820, Jun. 2025, :doi:`10.1016/j.renene.2025.122820`
760762
"""
761763
if module_type is None and coefficients is None:
762764
raise ValueError('Must provide either `module_type` or `coefficients`')
@@ -766,8 +768,7 @@ def spectral_factor_polo(precipitable_water, airmass_absolute, aod500, aoi,
766768
am_aoi = pvlib.atmosphere.get_relative_airmass(aoi)
767769
pressure = pvlib.atmosphere.alt2pres(altitude)
768770
am90 = pvlib.atmosphere.get_absolute_airmass(am_aoi, pressure)
769-
Ram = am90/airmass_absolute
770-
_coefficients = {}
771+
Ram = am90 / airmass_absolute
771772
_coefficients = {
772773
'cdte': (-0.0009, 46.80, 49.20, -0.87, 0.00041, 0.053),
773774
'monosi': (0.0027, 10.34, 9.48, 0.307, 0.00077, 0.006),

0 commit comments

Comments
 (0)