Restrict bucket names

[parkerrobbins]

https://docs.aws.amazon.com/awscloudtrail/latest/userguide/cloudtrail-s3-bucket-naming-requirements.html

Each label in the bucket name must start with a lowercase letter or number. The bucket name cannot contain underscores, end with a dash, have consecutive periods, or use dashes adjacent to periods.

[jkhartshorne]

Have you seen this be a problem? I was pretty sure I wrote the code to take care of that. Everything should be in lower case, with all punctuation removed. Did that not happen?

…

On Fri, Aug 28, 2020 at 9:57 AM Parker T. Robbins ***@***.***> wrote: https://docs.aws.amazon.com/awscloudtrail/latest/userguide/cloudtrail-s3-bucket-naming-requirements.html Each label in the bucket name must start with a lowercase letter or number. The bucket name cannot contain underscores, end with a dash, have consecutive periods, or use dashes adjacent to periods. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#157>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABOVVY4QGJVOC4YCS5ORELDSC6ZVRANCNFSM4QOFBLQQ> .

[parkerrobbins]

Yes, I tried using underscores. They were not removed.

[jkhartshorne]

This is why I should have learned regular expressions at some point. You are right. I've rewritten, but this isn't a good time to be pushing an update to the CLI. So please just don't use underscores in the meantime!

[jessestorbeck]

This update has been pushed out.

[jkhartshorne]

@jessestorbeck -- can you please reference the commit where it was addressed? I'd like to double-check it, since it's still on my local todo list as well.