feat: added a validation for gas_fee_used if success is true

Author: 0xNilesh

test/integration/uexecutor/gas_fee_refund_test.go

@@ -13,39 +13,28 @@ import (
 
 func TestGasFeeRefund(t *testing.T) {
 
-	t.Run("no refund when gasFeeUsed is empty", func(t *testing.T) {
+	t.Run("success vote with empty gasFeeUsed is rejected", func(t *testing.T) {
 		app, ctx, vals, utxId, outbound, coreVals :=
 			setupOutboundVotingTest(t, 4)
 
-		for i := 0; i < 3; i++ {
-			valAddr, err := sdk.ValAddressFromBech32(coreVals[i].OperatorAddress)
-			require.NoError(t, err)
-			coreAcc := sdk.AccAddress(valAddr).String()
-
-			err = utils.ExecVoteOutbound(
-				t,
-				ctx,
-				app,
-				vals[i],
-				coreAcc,
-				utxId,
-				outbound,
-				true,
-				"",
-				"", // gasFeeUsed empty → no refund
-			)
-			require.NoError(t, err)
-		}
-
-		utx, _, err := app.UexecutorKeeper.GetUniversalTx(ctx, utxId)
+		valAddr, err := sdk.ValAddressFromBech32(coreVals[0].OperatorAddress)
 		require.NoError(t, err)
-
-		ob := utx.OutboundTx[0]
-		require.Equal(t, uexecutortypes.Status_OBSERVED, ob.OutboundStatus)
-		require.True(t, ob.ObservedTx.Success)
-		// No refund should be triggered
-		require.Nil(t, ob.PcRefundExecution, "no refund expected when gasFeeUsed is empty")
-		require.Empty(t, ob.RefundSwapError)
+		coreAcc := sdk.AccAddress(valAddr).String()
+
+		err = utils.ExecVoteOutbound(
+			t,
+			ctx,
+			app,
+			vals[0],
+			coreAcc,
+			utxId,
+			outbound,
+			true,
+			"",
+			"", // gas_fee_used required when success=true → must be rejected
+		)
+		require.Error(t, err)
+		require.Contains(t, err.Error(), "gas_fee_used required when success=true")
 	})
 
 	t.Run("no refund when gasFeeUsed equals gasFee", func(t *testing.T) {

test/integration/uexecutor/vote_outbound_test.go

@@ -94,7 +94,7 @@ func TestOutboundVoting(t *testing.T) {
 			outbound,
 			true,
 			"",
-			"",
+			outbound.GasFee,
 		)
 		require.NoError(t, err)
 
@@ -126,7 +126,7 @@ func TestOutboundVoting(t *testing.T) {
 				outbound,
 				true,
 				"",
-				"",
+				outbound.GasFee,
 			)
 			require.NoError(t, err)
 		}
@@ -157,7 +157,7 @@ func TestOutboundVoting(t *testing.T) {
 			outbound,
 			true,
 			"",
-			"",
+			outbound.GasFee,
 		)
 		require.NoError(t, err)
 
@@ -171,7 +171,7 @@ func TestOutboundVoting(t *testing.T) {
 			outbound,
 			true,
 			"",
-			"",
+			outbound.GasFee,
 		)
 		require.Error(t, err)
 		require.Contains(t, err.Error(), "already voted")
@@ -196,7 +196,7 @@ func TestOutboundVoting(t *testing.T) {
 				outbound,
 				true,
 				"",
-				"",
+				outbound.GasFee,
 			)
 			require.NoError(t, err)
 		}
@@ -215,7 +215,7 @@ func TestOutboundVoting(t *testing.T) {
 			outbound,
 			true,
 			"",
-			"",
+			outbound.GasFee,
 		)
 		require.Error(t, err)
 		require.Contains(t, err.Error(), "already finalized")
@@ -320,7 +320,7 @@ func TestOutboundVoting(t *testing.T) {
 				&prefixedOutbound,
 				true,
 				"",
-				"",
+				outbound.GasFee,
 			)
 			require.NoError(t, err)
 		}
@@ -351,7 +351,7 @@ func TestOutboundVoting(t *testing.T) {
 			outbound,
 			true,
 			"",
-			"",
+			outbound.GasFee,
 		)
 		require.Error(t, err)
 		require.Contains(t, err.Error(), "not found")
@@ -377,7 +377,7 @@ func TestOutboundVoting(t *testing.T) {
 			&badOutbound,
 			true,
 			"",
-			"",
+			outbound.GasFee,
 		)
 		require.Error(t, err)
 		require.Contains(t, err.Error(), "not found")

x/uexecutor/types/msg_vote_outbound.go

@@ -69,7 +69,7 @@ func (msg *MsgVoteOutbound) ValidateBasic() error {
 	obs := msg.ObservedTx
 
 	if obs.Success {
-		// Success requires tx_hash AND block_height > 0
+		// Success requires tx_hash AND block_height > 0 AND gas_fee_used
 		if strings.TrimSpace(obs.TxHash) == "" {
 			return errors.Wrap(sdkerrors.ErrInvalidRequest,
 				"observed_tx.tx_hash required when success=true")
@@ -78,6 +78,10 @@ func (msg *MsgVoteOutbound) ValidateBasic() error {
 			return errors.Wrap(sdkerrors.ErrInvalidRequest,
 				"observed_tx.block_height must be > 0 when success=true")
 		}
+		if strings.TrimSpace(obs.GasFeeUsed) == "" {
+			return errors.Wrap(sdkerrors.ErrInvalidRequest,
+				"observed_tx.gas_fee_used required when success=true")
+		}
 
 	} else {
 		// Failure case: