fix: push core client

Author: Aman035

universalClient/core/client.go

@@ -8,7 +8,6 @@ import (
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/pushchain/push-chain-node/universalClient/api"
 	"github.com/pushchain/push-chain-node/universalClient/chains"
-	"github.com/pushchain/push-chain-node/universalClient/chains/common"
 	"github.com/pushchain/push-chain-node/universalClient/config"
 	"github.com/pushchain/push-chain-node/universalClient/constant"
 	"github.com/pushchain/push-chain-node/universalClient/db"
@@ -95,9 +94,6 @@ func NewUniversalClient(ctx context.Context, cfg *config.Config) (*UniversalClie
 			return nil, fmt.Errorf("failed to create Push database: %w", err)
 		}
 
-		// Create TxBuilderFactory that uses chains manager
-		txBuilderFactory := newChainsTxBuilderFactory(chainsManager)
-
 		tssCfg := tss.Config{
 			ValidatorAddress: cfg.PushValoperAddress,
 			P2PPrivateKeyHex: cfg.TSSP2PPrivateKeyHex,
@@ -107,7 +103,7 @@ func NewUniversalClient(ctx context.Context, cfg *config.Config) (*UniversalClie
 			Database:         pushDB,
 			PushCore:         pushCore,
 			Logger:           log,
-			TxBuilderFactory: txBuilderFactory,
+			Chains:           chainsManager,
 			PushSigner:       pushSigner,
 		}
 
@@ -207,29 +203,3 @@ func (uc *UniversalClient) Start() error {
 
 	return nil
 }
-
-// chainsTxBuilderFactory implements OutboundTxBuilderFactory using the chains manager
-type chainsTxBuilderFactory struct {
-	chains *chains.Chains
-}
-
-// newChainsTxBuilderFactory creates a new factory that uses the chains manager
-func newChainsTxBuilderFactory(chainsManager *chains.Chains) common.OutboundTxBuilderFactory {
-	return &chainsTxBuilderFactory{
-		chains: chainsManager,
-	}
-}
-
-// CreateBuilder creates an OutboundTxBuilder for the specified chain
-// TODO: Implement actual builder creation using chain clients
-func (f *chainsTxBuilderFactory) CreateBuilder(chainID string) (common.OutboundTxBuilder, error) {
-	// For now, return an error - this needs to be implemented
-	// The factory should get the chain client from chains manager and create a builder
-	return nil, fmt.Errorf("outbound tx builder creation not yet implemented for chain %s", chainID)
-}
-
-// SupportsChain returns true if this factory can create a builder for the chain
-func (f *chainsTxBuilderFactory) SupportsChain(chainID string) bool {
-	// TODO: Check if chain is available in chains manager
-	return false
-}

universalClient/core/client_test.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"testing"
 
-	"github.com/pushchain/push-chain-node/universalClient/chains"
 	"github.com/pushchain/push-chain-node/universalClient/config"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -82,73 +81,5 @@ func TestUniversalClientStruct(t *testing.T) {
 	})
 }
 
-func TestChainsTxBuilderFactory(t *testing.T) {
-	t.Run("CreateBuilder returns not implemented error", func(t *testing.T) {
-		factory := newChainsTxBuilderFactory(nil)
-
-		builder, err := factory.CreateBuilder("eip155:1")
-		require.Error(t, err)
-		assert.Nil(t, builder)
-		assert.Contains(t, err.Error(), "not yet implemented")
-		assert.Contains(t, err.Error(), "eip155:1")
-	})
-
-	t.Run("CreateBuilder with different chain IDs", func(t *testing.T) {
-		factory := newChainsTxBuilderFactory(nil)
-
-		testCases := []string{
-			"eip155:1",
-			"eip155:97",
-			"eip155:137",
-			"solana:mainnet",
-		}
-
-		for _, chainID := range testCases {
-			builder, err := factory.CreateBuilder(chainID)
-			require.Error(t, err, "expected error for chain %s", chainID)
-			assert.Nil(t, builder)
-			assert.Contains(t, err.Error(), chainID)
-		}
-	})
-
-	t.Run("SupportsChain returns false", func(t *testing.T) {
-		factory := newChainsTxBuilderFactory(nil)
-
-		testCases := []string{
-			"eip155:1",
-			"eip155:97",
-			"solana:mainnet",
-			"unknown-chain",
-		}
-
-		for _, chainID := range testCases {
-			supported := factory.SupportsChain(chainID)
-			assert.False(t, supported, "expected SupportsChain to return false for %s", chainID)
-		}
-	})
-
-	t.Run("factory with chains manager", func(t *testing.T) {
-		// Create a factory with a non-nil chains manager
-		// Even with a chains manager, the implementation returns not implemented
-		chainsManager := &chains.Chains{}
-		factory := newChainsTxBuilderFactory(chainsManager)
-
-		builder, err := factory.CreateBuilder("eip155:1")
-		require.Error(t, err)
-		assert.Nil(t, builder)
-		assert.Contains(t, err.Error(), "not yet implemented")
-	})
-}
-
-func TestNewChainsTxBuilderFactory(t *testing.T) {
-	t.Run("creates factory with nil chains", func(t *testing.T) {
-		factory := newChainsTxBuilderFactory(nil)
-		assert.NotNil(t, factory)
-	})
-
-	t.Run("creates factory with chains manager", func(t *testing.T) {
-		chainsManager := &chains.Chains{}
-		factory := newChainsTxBuilderFactory(chainsManager)
-		assert.NotNil(t, factory)
-	})
-}
+// Note: Factory tests removed as OutboundTxBuilderFactory has been replaced
+// with direct chain client access via Chains.GetClient() and ChainClient.GetTxBuilder()