Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BUG] - _addUser, batchSubscribe and batchUnsubscribe fn return hardcoded true #437

Closed
0xNilesh opened this issue Nov 20, 2024 · 0 comments
Closed

🐛 [BUG] - _addUser, batchSubscribe and batchUnsubscribe fn return hardcoded true #437

0xNilesh opened this issue Nov 20, 2024 · 0 comments
Assignees
@Zartaj0
Labels
bug Something isn't working priority-2 Medium priority

Comments

@0xNilesh
Copy link
Member

Expected Behaviour

If the hardcoded boolean is getting returned, it will make no difference even if that return is removed.
It makes more sense to remove those

Current Behaviour

Some functions return a hardcoded boolean which isn't necessary

Reproduction steps

.

Screenshots

![DESCRIPTION](LINK.png)

POC if available

No response

Contract Name

Comm Contract

Chains

No response
@0xNilesh 0xNilesh added the bug Something isn't working label Nov 20, 2024
@zaryab2000 zaryab2000 added the priority-2 Medium priority label Dec 17, 2024
@Zartaj0 Zartaj0 mentioned this issue Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zartaj0 Zartaj0

Labels
bug Something isn't working priority-2 Medium priority
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

439-bug-fixes push-protocol/push-smart-contracts
3 participants
@zaryab2000 @0xNilesh @Zartaj0