Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - Channel alias verification won't be possible in case of hard fork #436

Closed
0xNilesh opened this issue Nov 20, 2024 · 0 comments
Assignees
Labels
bug Something isn't working priority-2 Medium priority

Comments

@0xNilesh
Copy link
Member

Expected Behaviour

verifyChannelAlias fn should work in case hard fork happens

Current Behaviour

since chainId variable from storage is used in the verifyChannelAlias, and there is no setter fn available for that
In case of hard fork, it'd emit wrong chain id

Reproduction steps

.

Screenshots

![DESCRIPTION](LINK.png)

POC if available

No response

Contract Name

Comm Contract

Chains

No response

@0xNilesh 0xNilesh added the bug Something isn't working label Nov 20, 2024
@zaryab2000 zaryab2000 added the priority-2 Medium priority label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-2 Medium priority
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants