New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

❓ [Support] - <Include PUSH DID Feature for COMM_ETH Contract> #363

Closed

zaryab2000 opened this issue May 22, 2024 · 0 comments · Fixed by #344

Assignees

Labels

priority-1 support

Milestone

Collaborator

zaryab2000 commented May 22, 2024

Question or Support Request

Push DID feature currently includes fee pool for comm contracts
While that's right for other EVM Chains, it won't be valid for ETH COMM Contract since ETH Already has a fee pool
Include an implementation of PUSH DID Feature specificially for COMM ETH where fees are transferred to CORE. (addPoolFees can be used to make this transfer)

zaryab2000 added priority-1 support labels

zaryab2000 added this to the Push Core V3 milestone

zaryab2000 assigned Zartaj0

Zartaj0 linked a pull request

that will close this issue

Added first draft for DID PGP feature #344

Merged

zaryab2000 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment