Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

😈 [Feature Enhancement] - <Review and fixes of Custom error changes in core and comm> #257

Closed
zaryab2000 opened this issue Jan 10, 2024 · 0 comments · Fixed by #260
Closed
Assignees
Labels
bug Something isn't working priority-2 Medium priority

Comments

@zaryab2000
Copy link
Collaborator

Feature name

The custom error changes have been implemented but due to lack of test case or issues with migration , its possible that some bugs are still remaining.

Describe the Enhancement

A separate branch to mainly identify and resolve the following issues with custom error changes:

  • Accuracy and intented behavior check
  • Optimization checks
  • Identify if there are lack of test cases for any specific scenario related to custom error changes (since most of those changes deal with important checkpoints/conditions)

POC if available

No response

Contract Name

Core Contract, Comm Contract, Push Staking V2

@zaryab2000 zaryab2000 added bug Something isn't working priority-2 Medium priority labels Jan 10, 2024
@0xNilesh 0xNilesh self-assigned this Jan 10, 2024
@0xNilesh 0xNilesh linked a pull request Jan 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-2 Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants