Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

😈 [Feature Enhancement] - <Use unchecked{} block for loops and where necessary> #255

Closed
zaryab2000 opened this issue Jan 10, 2024 · 0 comments · Fixed by #258
Closed

😈 [Feature Enhancement] - <Use unchecked{} block for loops and where necessary> #255

zaryab2000 opened this issue Jan 10, 2024 · 0 comments · Fixed by #258
Assignees
@0xNilesh
Labels
enhancement New feature or request priority-1 Indicates highest priority
Milestone
Push Core V2.5 (a...

Comments

@zaryab2000
Copy link
Collaborator

Feature name

The current contract design doesn't utilize the unchecked block feature

Describe the Enhancement

Desired behavior would be to have unchecked blocks used wherever necessary. This involves mostly the for loops in all contracts.

POC if available

No response

Contract Name

Core Contract, Comm Contract, Push Staking V2
@zaryab2000 zaryab2000 added enhancement New feature or request priority-1 Indicates highest priority labels Jan 10, 2024
@0xNilesh 0xNilesh linked a pull request Jan 10, 2024 that will close this issue
Added unchecked blocks in loops for gas optimization #258
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xNilesh 0xNilesh

Labels
enhancement New feature or request priority-1 Indicates highest priority
Projects
None yet
Milestone
Push Core V2.5 (and Clean-Ups)
Development

Successfully merging a pull request may close this issue.

Added unchecked blocks in loops for gas optimization push-protocol/push-smart-contracts
2 participants
@zaryab2000 @0xNilesh