Skip to content

feat: added default link markdown support in default patterns - #825

Merged
mishramonalisha76 merged 2 commits into
alphafrom
notification-markdown-link
Nov 9, 2023
Merged

mishramonalisha76 merged 2 commits into
alphafrom
notification-markdown-link

Conversation

@KlausMikhaelson

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Nov 8, 2023

Copy link
Copy Markdown

There are several mistakes and typos in the code:

  1. In the first line, the shebang should be #!/bin/bash instead of #!/bin/sh.

  2. There is an unnecessary import statement for CustomParseShape in line 9. It should be removed.

  3. There is a typo in the comment in line 11. "patters" should be "patterns".

  4. In the newLinestyles function, there is an unnecessary console.log statement in line 15. It should be removed.

  5. In the same newLinestyles function, there is an unnecessary console.log statement in line 18. It should be removed.

  6. In the renderTextStyles function, the regular expression pattern in line 30 is missing a closing slash. It should be /i; instead of /i.

  7. In the same renderTextStyles function, the switch case for "tertiary" color in lines 38-40 has a typo. "third" should be "tertiary".

  8. In the renderLinkWithColor function, the regular expression linkPattern in line 53 is missing a closing parenthesis. It should be /([^\]]+)]\((https?:\/\/[^)]+)/.

  9. In the same renderLinkWithColor function, the switch case for "tertiary" color in lines 72-74 has a typo. "third" should be "tertiary".

  10. In the renderLinkWithColor function, the else if statement condition in lines 80-82 should be if (markdownLinkPattern) instead of if (match).

  11. In the same renderLinkWithColor function, the else if statement condition in lines 80-82 is unnecessary and can be removed.

  12. There is a typo in the comment in line 86. "addional" should be "additional".

  13. In the convertEpochToHumanReadable function, the regular expression pattern in line 103 is missing a closing parenthesis. It should be /\[ts: (\d+)\]/.

  14. There is an unnecessary empty line after the convertEpochToHumanReadable function. It should be removed.

  15. There is an unnecessary empty line after the const DEFAULT_PATTERNS declaration. It should be removed.

Apart from these mistakes and typos, the logic and code structure seem fine.

All looks good.

@github-actions

github-actions Bot commented Nov 9, 2023

Copy link
Copy Markdown
  • The import statement for CustomParseShape is missing. It should be imported from './customParser.types'.
  • There is an extra closing curly brace } at the end of the file.

@mishramonalisha76
mishramonalisha76 merged commit 54f6ee4 into alpha Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants