Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support chat v2 added #1236

Merged
merged 4 commits into from
Apr 25, 2024
Merged

feat: support chat v2 added #1236

merged 4 commits into from
Apr 25, 2024

Conversation

mishramonalisha76
Copy link
Contributor

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

All looks good.

@mishramonalisha76 mishramonalisha76 linked an issue Apr 18, 2024 that may be closed by this pull request
Copy link

In ChatSupportTest.tsx:

  1. The key property should be defined inside curly braces: key={'460336a9fa83112c95894af5471cd2b1091290a11298d87ec824ed74b7c14974'}.
  2. There is an unused commented out component , consider removing it.
  3. Make sure to handle closing div tag properly.

In ChatProfile.tsx:

  1. There is a missing closing brace in the customStyle prop object.

In ChatViewBubble.tsx:

  1. There is a syntax error in the MessageCard component definition. The position needs to be declared as a variable before usage: const MessageCard = ({ chat, position, number, time = moment(chat.timestamp).format('hh:mm a') }) => {...}.
  2. There are multiple missing closing braces and if conditions need curly braces, e.g., if (position) {...}.
  3. In the FileCard component, there is a missing closing angle bracket after gap="15px".

Other files seem to be snippet placeholders or empty.

Please review and make necessary corrections.

Overall status: Code needs minor corrections and some syntax adjustments.

If you have any questions or need further assistance, feel free to ask.

@mishramonalisha76 mishramonalisha76 merged commit 4cded05 into alpha Apr 25, 2024
1 check passed
Copy link

In the file packages/examples/sdk-frontend-react/src/app/ChatSupportTest.tsx:

  • Typo: 'key=' should be 'apiKey='

In the file packages/examples/sdk-frontend-react/src/app/app.tsx:

  • Typo: 'position: number;' should be 'const position: number;'
  • There are missing closing tags for multiple elements

In the file packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfile.tsx:

  • Typo: 'bottom="6px"' should be 'bottom="6px"'

In the file packages/uiweb/src/lib/components/chat/ChatViewBubble/ChatViewBubble.tsx:

  • Typos: Multiple instances of missing '?' before ternary conditions
  • There are missing closing tags for elements like
    and

In the file packages/uiweb/src/lib/components/chat/ChatViewList/ChatViewList.tsx:

  • No specific issues found

In the file packages/uiweb/src/lib/components/chat/MessageInput/MessageInput.tsx:

  • No specific issues found

In the file packages/uiweb/src/lib/components/chat/theme/index.ts:

  • No specific issues found

In the rest of the files, no specific issues were found.

Overall, the code needs some corrections for typos and missing/incorrect syntax.
If you make the necessary corrections, it should be good to go.

mishramonalisha76 added a commit that referenced this pull request Apr 25, 2024
* feat: support chat v2 added

* fix: changed supportchatv2 to chatwidget

* fix: changed support chat to chatwidget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Support Chat under Chat Provider
2 participants